Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Doc]: Get-AzWebApp needs to make -ResourceGroupName a required parameter for optimal results #17184

Closed
Xingyixzhang opened this issue Feb 18, 2022 · 7 comments
Assignees
Labels
App Services aka WebSites bug This issue requires a change to an existing behavior in the product in order to be resolved. customer-reported CXP Attention [Deprecated] The Azure CXP Support Team is responsible for this issue. needs-author-feedback More information is needed from author to address the issue. question The issue doesn't require a change to the product in order to be resolved. Most issues start as that

Comments

@Xingyixzhang
Copy link

Description

Document Link

https://docs.microsoft.com/en-us/powershell/module/az.websites/get-azwebapp?view=azps-7.2.0&viewFallbackFrom=azps-7.2

Issue

The command below with and without the -ResourceGroupName parameter returns different results, yet the document does not specify that the -ResourceGroupName should be a required field.

$apps = Get-azWebApp (-ResourceGroupName)

foreach($a in $apps){
    $a.name
    $a.siteconfig.FtpsState
}

Demonstration on Expected Results (with the parameter, the FtpsState value showed up correctly)

image

Demonstration on Actual Results (without the parameter, the FtpsState value showed up null)

image

Additional findings

Many other values are missing when the -ResourceGroupName parameter is not set. Feel free to check full detailed SiteConfig comparisons running the following commands:

Get-azWebApp | ConvertTo-Json
Get-azWebApp -ResourceGroupName "YourRGName" | ConvertTo-Json

Recommendation

Make the -ResourceGroupName a required parameter so that customers can achieve the desired results.

@Xingyixzhang Xingyixzhang added the needs-triage This is a new issue that needs to be triaged to the appropriate team. label Feb 18, 2022
@ghost ghost added question The issue doesn't require a change to the product in order to be resolved. Most issues start as that customer-reported labels Feb 18, 2022
@Xingyixzhang Xingyixzhang changed the title [Doc]: Get-AzWebApp [Doc]: Get-AzWebApp needs to make -ResourceGroupName a required parameter for optimal results Feb 18, 2022
@dingmeng-xue dingmeng-xue added App Services aka WebSites Service Attention This issue is responsible by Azure service team. labels Feb 19, 2022
@ghost ghost removed the needs-triage This is a new issue that needs to be triaged to the appropriate team. label Feb 19, 2022
@ghost
Copy link

ghost commented Feb 19, 2022

Thanks for the feedback! We are routing this to the appropriate team for follow-up. cc @antcp, @AzureAppServiceCLI.

Issue Details

Description

Document Link

https://docs.microsoft.com/en-us/powershell/module/az.websites/get-azwebapp?view=azps-7.2.0&viewFallbackFrom=azps-7.2

Issue

The command below with and without the -ResourceGroupName parameter returns different results, yet the document does not specify that the -ResourceGroupName should be a required field.

$apps = Get-azWebApp (-ResourceGroupName)

foreach($a in $apps){
    $a.name
    $a.siteconfig.FtpsState
}

Demonstration on Expected Results (with the parameter, the FtpsState value showed up correctly)

image

Demonstration on Actual Results (without the parameter, the FtpsState value showed up null)

image

Additional findings

Many other values are missing when the -ResourceGroupName parameter is not set. Feel free to check full detailed SiteConfig comparisons running the following commands:

Get-azWebApp | ConvertTo-Json
Get-azWebApp -ResourceGroupName "YourRGName" | ConvertTo-Json

Recommendation

Make the -ResourceGroupName a required parameter so that customers can achieve the desired results.

Author: Xingyixzhang
Assignees: -
Labels:

App Services, Service Attention, question, customer-reported, needs-triage

Milestone: -

@dingmeng-xue dingmeng-xue added CXP Attention [Deprecated] The Azure CXP Support Team is responsible for this issue. and removed Service Attention This issue is responsible by Azure service team. labels Feb 19, 2022
@ghost
Copy link

ghost commented Feb 19, 2022

Thank you for your feedback. This has been routed to the support team for assistance.

1 similar comment
@ghost
Copy link

ghost commented Feb 19, 2022

Thank you for your feedback. This has been routed to the support team for assistance.

@ghost ghost added the needs-team-triage label Feb 19, 2022
@navba-MSFT navba-MSFT self-assigned this Feb 21, 2022
@navba-MSFT
Copy link
Contributor

@Xingyixzhang Apologies for the late reply. I am looking into this issue. I will get back on this thread once I have more details on this.

@navba-MSFT
Copy link
Contributor

@Xingyixzhang Please check the similar issue being reported here #9168.

As a workaround, you can get the consistent result using the Get-AzResource PS cmdlet.

$siteConfig = Get-AzResource -ResourceGroupName 'MyRGName' -Name 'MyResourceName' -ResourceType Microsoft.Web/sites/config -ApiVersion 2021-03-01

$siteConfig.Properties.ftpsState

cc: @panchagnula

@navba-MSFT navba-MSFT added needs-author-feedback More information is needed from author to address the issue. bug This issue requires a change to an existing behavior in the product in order to be resolved. and removed needs-team-triage labels Feb 21, 2022
@Kotasudhakarreddy Kotasudhakarreddy self-assigned this Feb 25, 2022
@panchagnula
Copy link
Contributor

@Xingyixzhang / @navba-MSFT making an argument required from optional is a breaking change since currently this command can be run on Sub level, RG level or app level. @navba-MSFT we should close since this is not possible for now.

@navba-MSFT
Copy link
Contributor

Thanks @panchagnula for your reply.

@Xingyixzhang I hope you had a chance to look at the above comment. We will now proceed with the closure as this feature would be a breaking change and not it is not possible to add now. If you have any further questions, please feel free to reopen this thread.

BethanyZhou added a commit that referenced this issue Mar 9, 2022
…fig in `Set-AzWebApp`, `Set-AzWebAppSlot`, `Get-AzWebApp` and `Get-AzWebAppSlot` (#17326)

* Fix #17184 :  `Get-AzWebApp` to return SiteConfig details in the response when requested the WebApps under subscreption

* Revert "Fix #17184 :  `Get-AzWebApp` to return SiteConfig details in the response when requested the WebApps under subscreption"

This reverts commit 96a4d28.

* Fix #16325- Expose HealthCheckPath SiteConfig

* Addressed review comments

* Review comments

Co-authored-by: Beisi Zhou <[email protected]>
BethanyZhou added a commit that referenced this issue Mar 16, 2022
…perty in Set-AzWebApp, Set-AzWebAppSlot, Get-AzWebApp and Get-AzWebAppSlot (#17465)

* Fix #17184 :  `Get-AzWebApp` to return SiteConfig details in the response when requested the WebApps under subscreption

* Revert "Fix #17184 :  `Get-AzWebApp` to return SiteConfig details in the response when requested the WebApps under subscreption"

This reverts commit 96a4d28.

* Fix#15663_Expose_vnetRouteAllEnabled Property

* Updated Changelog.md

* Update src/Websites/Websites/ChangeLog.md

Accepted

Co-authored-by: Beisi Zhou <[email protected]>

* Update src/Websites/Websites/ChangeLog.md

* Update src/Websites/Websites/ChangeLog.md

Co-authored-by: Beisi Zhou <[email protected]>
BethanyZhou pushed a commit that referenced this issue Mar 29, 2022
…ng new Tags (#17650)

* Fix #17184 :  `Get-AzWebApp` to return SiteConfig details in the response when requested the WebApps under subscreption

* Revert "Fix #17184 :  `Get-AzWebApp` to return SiteConfig details in the response when requested the WebApps under subscreption"

This reverts commit 96a4d28.

* Fix #17184 :  `Get-AzWebApp` to return SiteConfig details in the response when requested the WebApps under subscreption

* Revert "Fix #17184 :  `Get-AzWebApp` to return SiteConfig details in the response when requested the WebApps under subscreption"

This reverts commit 96a4d28.

* Fixed Set-AzAppServicePlan to keep existing Tags when adding new Tags
BethanyZhou pushed a commit that referenced this issue Mar 29, 2022
…t setting TLS version for WebApp Slots (#17664)

* Fix #17184 :  `Get-AzWebApp` to return SiteConfig details in the response when requested the WebApps under subscreption

* Revert "Fix #17184 :  `Get-AzWebApp` to return SiteConfig details in the response when requested the WebApps under subscreption"

This reverts commit 96a4d28.

* Fix #17184 :  `Get-AzWebApp` to return SiteConfig details in the response when requested the WebApps under subscreption

* Revert "Fix #17184 :  `Get-AzWebApp` to return SiteConfig details in the response when requested the WebApps under subscreption"

This reverts commit 96a4d28.

* Fix:#17663 : Enable MinTlsVersion
isra-fel added a commit that referenced this issue Apr 12, 2022
…s obsolete (#17303)

* Fix #17184 :  `Get-AzWebApp` to return SiteConfig details in the response when requested the WebApps under subscreption

* Revert "Fix #17184 :  `Get-AzWebApp` to return SiteConfig details in the response when requested the WebApps under subscreption"

This reverts commit 96a4d28.

* Fix #16646 - Updated 'New-AzWebAppContainerPSSession' with CmdletDeprecation Attribute

Co-authored-by: Yeming Liu <[email protected]>
wyunchi-ms pushed a commit that referenced this issue May 11, 2022
…`VirtualNetworkSubnetId` property (#18092)

* Fix #17184 :  `Get-AzWebApp` to return SiteConfig details in the response when requested the WebApps under subscreption

* Revert "Fix #17184 :  `Get-AzWebApp` to return SiteConfig details in the response when requested the WebApps under subscreption"

This reverts commit 96a4d28.

* Fix #17184 :  `Get-AzWebApp` to return SiteConfig details in the response when requested the WebApps under subscreption

* Revert "Fix #17184 :  `Get-AzWebApp` to return SiteConfig details in the response when requested the WebApps under subscreption"

This reverts commit 96a4d28.

* [AppServices]: Fix #18042 : Updated `Get-AzWebApp` and `Get-AzWebAppSlot` to expose `VirtualNetworkSubnetId` property
BethanyZhou added a commit that referenced this issue Jul 25, 2022
…ths properly (#18977)

* Fix #17184 :  `Get-AzWebApp` to return SiteConfig details in the response when requested the WebApps under subscreption

* Revert "Fix #17184 :  `Get-AzWebApp` to return SiteConfig details in the response when requested the WebApps under subscreption"

This reverts commit 96a4d28.

* Fix #17184 :  `Get-AzWebApp` to return SiteConfig details in the response when requested the WebApps under subscreption

* Revert "Fix #17184 :  `Get-AzWebApp` to return SiteConfig details in the response when requested the WebApps under subscreption"

This reverts commit 96a4d28.

* [AppService]: fix #18028- Publish-AzWebapp doesn't handle relative paths properly

* Updated changelog.md

* Update src/Websites/Websites/ChangeLog.md

* Fixed an issue

* Updated review comments

Co-authored-by: Beisi Zhou <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
App Services aka WebSites bug This issue requires a change to an existing behavior in the product in order to be resolved. customer-reported CXP Attention [Deprecated] The Azure CXP Support Team is responsible for this issue. needs-author-feedback More information is needed from author to address the issue. question The issue doesn't require a change to the product in order to be resolved. Most issues start as that
Projects
None yet
Development

No branches or pull requests

5 participants