Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AppService]: fix #18028- Publish-AzWebapp doesn't handle relative paths properly #18977

Merged
merged 10 commits into from
Jul 25, 2022
Merged

[AppService]: fix #18028- Publish-AzWebapp doesn't handle relative paths properly #18977

merged 10 commits into from
Jul 25, 2022

Conversation

Kotasudhakarreddy
Copy link
Contributor

Description

#18028

Public-AzWebapp interprets relative paths incorrectly.

Any relative path I use is appended to c:\windows\system32. There was a previous report of this which was closed without a proper explanation.

PS > Publish-AzWebApp -ResourceGroupName POC -Name Test -ArchivePath ".\TestApp\TestApp.zip" -Force
Publish-AzWebApp: Could not find a part of the path 'C:\Windows\system32\TestApp\TestApp.zip'.

Checklist

  • SHOULD select appropriate branch. Cmdlets from Autorest.PowerShell should go to generation branch.
  • SHOULD make the title of PR clear and informative, and in the present imperative tense.
  • SHOULD update ChangeLog.md file(s) appropriately
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense. Add changelog in description section if PR goes into generation branch.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD have approved design review for the changes in this repository (Microsoft internal only) with following situations
    • Create new module from the scratch
    • Create new resource types which are not easy to conform to Azure PowerShell Design Guidelines
    • Create new resource type which name doesn't use module name as prefix
    • Have design question before implementation
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT introduce breaking changes in Az minor release except preview version.
  • SHOULD NOT change version of module in pull request

…nse when requested the WebApps under subscreption
…he response when requested the WebApps under subscreption"

This reverts commit 96a4d28.
…nse when requested the WebApps under subscreption
…he response when requested the WebApps under subscreption"

This reverts commit 96a4d28.
BethanyZhou
BethanyZhou previously approved these changes Jul 20, 2022
Copy link
Contributor

@BethanyZhou BethanyZhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.

@BethanyZhou BethanyZhou self-requested a review July 20, 2022 03:19
@BethanyZhou BethanyZhou dismissed their stale review July 20, 2022 03:19

hold on

@BethanyZhou BethanyZhou added the needs-author-feedback More information is needed from author to address the issue. label Jul 20, 2022
@BethanyZhou
Copy link
Contributor

/azp run azure-powershell - security-tools

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 1 pipeline(s).

@BethanyZhou BethanyZhou added needs-revision and removed needs-author-feedback More information is needed from author to address the issue. labels Jul 21, 2022
@Kotasudhakarreddy Kotasudhakarreddy added needs-author-feedback More information is needed from author to address the issue. and removed needs-revision labels Jul 21, 2022
@BethanyZhou
Copy link
Contributor

/azp run azure-powershell - security-tools

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 1 pipeline(s).

@BethanyZhou BethanyZhou added Waiting for CI :shipit: and removed needs-author-feedback More information is needed from author to address the issue. labels Jul 25, 2022
@BethanyZhou BethanyZhou merged commit 2cee39f into Azure:main Jul 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants