-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AppService]: fix #18028- Publish-AzWebapp doesn't handle relative paths properly #18977
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BethanyZhou
reviewed
Jul 20, 2022
BethanyZhou
previously approved these changes
Jul 20, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.
BethanyZhou
reviewed
Jul 20, 2022
BethanyZhou
added
the
needs-author-feedback
More information is needed from author to address the issue.
label
Jul 20, 2022
/azp run azure-powershell - security-tools |
Azure Pipelines successfully started running 1 pipeline(s). |
BethanyZhou
suggested changes
Jul 21, 2022
BethanyZhou
added
needs-revision
and removed
needs-author-feedback
More information is needed from author to address the issue.
labels
Jul 21, 2022
Kotasudhakarreddy
added
needs-author-feedback
More information is needed from author to address the issue.
and removed
needs-revision
labels
Jul 21, 2022
/azp run azure-powershell - security-tools |
Azure Pipelines successfully started running 1 pipeline(s). |
BethanyZhou
approved these changes
Jul 25, 2022
BethanyZhou
added
Waiting for CI
and removed
needs-author-feedback
More information is needed from author to address the issue.
labels
Jul 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#18028
Public-AzWebapp interprets relative paths incorrectly.
Any relative path I use is appended to c:\windows\system32. There was a previous report of this which was closed without a proper explanation.
PS > Publish-AzWebApp -ResourceGroupName POC -Name Test -ArchivePath ".\TestApp\TestApp.zip" -Force
Publish-AzWebApp: Could not find a part of the path 'C:\Windows\system32\TestApp\TestApp.zip'.
Checklist
CONTRIBUTING.md
and reviewed the following information:generation
branch.ChangeLog.md
file(s) appropriatelyChangeLog.md
file can be found atsrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
## Upcoming Release
header in the past tense. Add changelog in description section if PR goes intogeneration
branch.ChangeLog.md
if no new release is required, such as fixing test case only.