Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AppServices]: Fix #17184 : Get-AzWebApp to return SiteConfig details in the response when requested the WebApps under subscreption #17269

Closed
wants to merge 2 commits into from

Conversation

Kotasudhakarreddy
Copy link
Contributor

#17184

Description

Get-AzWebApp is not returning SiteConfig details in the response object when requested the WebApps under subscreption

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
      • {Please put the link here}
    • the markdown help files have been regenerated using the commands listed here

…nse when requested the WebApps under subscreption
src/Websites/Websites/ChangeLog.md Outdated Show resolved Hide resolved
@panchagnula
Copy link
Contributor

looking at this PR - the siteConfig is available when using -RG or -webapp in the command & this is adding for when querying on Sub directly, is this correct? If so this is by design , since Site & SiteConfig are separate API calls & Subscriptions can have 100's of Webapps - for performance reasons & good user experience purposes, SiteConfig will be available only when using RG and/or webapp directly.

Copy link
Contributor

@panchagnula panchagnula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

when using Get-AzWebapp directly on Sub level, SiteConfig will not be supported, since this is an additional API call for each app on Sub. SiteConfig requires a RG or webapp in the command.

@BethanyZhou
Copy link
Contributor

Just for sure, this PR closed as this feature should not be change, right? @panchagnula

@panchagnula
Copy link
Contributor

Correct - the current experience is by design & so we shouldn't make this change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants