Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AppServices]: Fix #16325 and #14624 : Expose HealthCheckPath SiteConfig in Set-AzWebApp, Set-AzWebAppSlot, Get-AzWebApp and Get-AzWebAppSlot #17326

Merged
merged 7 commits into from
Mar 9, 2022

Conversation

Kotasudhakarreddy
Copy link
Contributor

#16325 , #14624

Description

The current Set-AzWebApp does not expose the SiteConfig "HealthCheckPath" parameter. We want to automate setting the "HealthCheckPath".

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
      • {Please put the link here}
    • the markdown help files have been regenerated using the commands listed here

…nse when requested the WebApps under subscreption
…he response when requested the WebApps under subscreption"

This reverts commit 96a4d28.
BethanyZhou
BethanyZhou previously approved these changes Mar 3, 2022
Copy link
Contributor

@BethanyZhou BethanyZhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

BethanyZhou
BethanyZhou previously approved these changes Mar 3, 2022
Copy link
Contributor

@panchagnula panchagnula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments

@BethanyZhou
Copy link
Contributor

@Kotasudhakarreddy , @panchagnula , please let me know when this PR is ready

@BethanyZhou BethanyZhou added the needs-author-feedback More information is needed from author to address the issue. label Mar 3, 2022
@Kotasudhakarreddy
Copy link
Contributor Author

See comments

Addressed all the comments given.

@Kotasudhakarreddy Kotasudhakarreddy added needs-review and removed needs-author-feedback More information is needed from author to address the issue. labels Mar 3, 2022
@BethanyZhou
Copy link
Contributor

/azp run azure-powershell - security-tools

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 1 pipeline(s).

@BethanyZhou BethanyZhou merged commit c236f7e into Azure:main Mar 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants