feat: removing superfluous call to MSM

[benesjan]

Fixes #7551

[benesjan]

• feat: removing superfluous call to MSM #7708 👈
• master

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @benesjan and the rest of your teammates on Graphite

[benesjan]

I've manually implemented this function here because of #7738

This is a good tradeoff because it makes the token be more closer to final version when it comes to gate counts (because in the future we will most likely make the macros generate this function such that it does exactly what this impl does). On master now this function does 2 MSM calls which is very expensive and can skew our measurements significantly (@nventuro this is possibly why you so the gate counts rise yesterday I merged the PR with 2 MSM calls yesterday).

[benesjan]

Did this change here because TokenContract can no longer be used with the standard computeNoteHidingPoint func.

[sklppy88]

Nice 👍

[AztecBot]

Benchmark results

Metrics with a significant change:

• avm_simulation_time_ms (Token:assert_minter_and_mint): 84.3 (+49%)
• avm_simulation_time_ms (AuthRegistry:set_authorized): 13.1 (+44%)
• avm_simulation_time_ms (Token:transfer_public): 69.3 (+107%)
• avm_simulation_time_ms (Token:_increase_public_balance): 59.3 (+367%)
• protocol_circuit_proving_time_in_ms (base-parity): 1,946 (+39%)

Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Proof generation

Each column represents the number of threads used in proof generation.

Metric	1 threads	4 threads	16 threads	32 threads	64 threads
proof_construction_time_sha256_ms	5,728	1,544	702	730 (-1%)	762 (-1%)
proof_construction_time_sha256_30_ms	11,730	3,141	1,404	1,437	1,462 (-1%)
proof_construction_time_sha256_100_ms	43,786	12,352 (+1%)	5,642	5,564	5,466
proof_construction_time_poseidon_hash_ms	78.0	34.0	34.0	59.0	88.0
proof_construction_time_poseidon_hash_30_ms	1,520	417	200	223 (-4%)	266 (+1%)
proof_construction_time_poseidon_hash_100_ms	5,612	1,512	677	749 (+3%)	746

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric	4 txs	8 txs	16 txs
l1_rollup_calldata_size_in_bytes	740	740	740
l1_rollup_calldata_gas	6,704	6,734	6,716
l1_rollup_execution_gas	611,971	612,152	612,285
l2_block_processing_time_in_ms	755 (+2%)	1,409	2,670 (+1%)
l2_block_building_time_in_ms	10,184 (+1%)	19,797	39,201
l2_block_rollup_simulation_time_in_ms	10,184 (+1%)	19,797	39,200
l2_block_public_tx_process_time_in_ms	8,463 (+1%)	17,889	37,211

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 8 txs.

Metric	3 blocks	5 blocks
node_history_sync_time_in_ms	6,919 (-1%)	9,853 (-1%)
node_database_size_in_bytes	12,709,968	16,891,984
pxe_database_size_in_bytes	16,254	26,813

Circuits stats

Stats on running time and I/O sizes collected for every kernel circuit run across all benchmarks.

Circuit	simulation_time_in_ms	witness_generation_time_in_ms	input_size_in_bytes	output_size_in_bytes	proving_time_in_ms	proof_size_in_bytes	num_public_inputs	size_in_gates
private-kernel-init	106 (-1%)	395 (-5%)	21,755	44,858	N/A	N/A	N/A	N/A
private-kernel-inner	174	682 (-6%)	72,541	45,005	N/A	N/A	N/A	N/A
private-kernel-tail	725 (-1%)	920 (-4%)	53,065	46,792	N/A	N/A	N/A	N/A
base-parity	6.45	643 (+2%)	160	96.0	⚠️ 1,946 (+39%)	13,188	19.0	131,072
root-parity	114 (+1%)	126 (-2%)	69,084	96.0	32,061	13,188	19.0	4,194,304
base-rollup	3,224 (-1%)	4,834 (-5%)	182,288	664	43,928 (-3%)	14,020	45.0	4,194,304
root-rollup	155 (-1%)	127 (+2%)	54,525	716	28,598 (+3%)	13,988	44.0	4,194,304
public-kernel-setup	89.5 (+4%)	2,647 (-3%)	98,521	65,718	17,574 (-7%)	123,076	3,453	2,097,152
public-kernel-app-logic	101	3,940 (-3%)	98,521	65,718	11,021 (-4%)	123,076	3,453	1,048,576
public-kernel-tail	619	25,697 (+2%)	396,198	10,878	66,263 (-2%)	26,436	433	8,388,608
private-kernel-reset-tiny	227 (-1%)	876 (-5%)	68,568	44,750	N/A	N/A	N/A	N/A
private-kernel-tail-to-public	5,146 (-4%)	1,763 (+5%)	919,213	1,697	N/A	N/A	N/A	N/A
public-kernel-teardown	82.4	3,970	98,521	65,718	19,334 (-2%)	123,076	3,453	2,097,152
merge-rollup	60.1	N/A	35,742	664	N/A	N/A	N/A	N/A
undefined	N/A	N/A	N/A	N/A	157,038	N/A	N/A	N/A

Stats on running time collected for app circuits

Function	input_size_in_bytes	output_size_in_bytes	witness_generation_time_in_ms	proof_size_in_bytes	proving_time_in_ms
ContractClassRegisterer:register	1,344	11,731	347	N/A	N/A
ContractInstanceDeployer:deploy	1,408	11,731	27.3 (-1%)	N/A	N/A
MultiCallEntrypoint:entrypoint	1,920	11,731	604 (-1%)	N/A	N/A
GasToken:deploy	1,376	11,731	445 (+1%)	N/A	N/A
SchnorrAccount:constructor	1,312	11,731	428	N/A	N/A
SchnorrAccount:entrypoint	2,304	11,731	817	N/A	N/A
Token:privately_mint_private_note	1,280	11,731	508 (+1%)	N/A	N/A
FPC:fee_entrypoint_public	1,344	11,731	93.2 (+5%)	N/A	N/A
Token:transfer	1,312	11,731	1,281 (+1%)	N/A	N/A
AuthRegistry:set_authorized (avm)	18,491	N/A	N/A	102,112	1,887 (-5%)
FPC:prepare_fee (avm)	22,958	N/A	N/A	102,176	2,145 (-2%)
Token:transfer_public (avm)	46,881	N/A	N/A	102,176	6,385 (-3%)
AuthRegistry:consume (avm)	26,734	N/A	N/A	102,144	2,501 (-2%)
FPC:pay_refund (avm)	26,227	N/A	N/A	102,144	3,471 (-1%)
Benchmarking:create_note	1,344	11,731	418	N/A	N/A
SchnorrAccount:verify_private_authwit	1,280	11,731	44.5 (-3%)	N/A	N/A
Token:unshield	1,376	11,731	1,077 (-1%)	N/A	N/A
FPC:fee_entrypoint_private	1,376	11,731	1,398	N/A	N/A

AVM Simulation

Time to simulate various public functions in the AVM.

Function	time_ms	bytecode_size_in_bytes
GasToken:_increase_public_balance	96.7	8,139
GasToken:set_portal	14.4 (-7%)	2,362
Token:constructor	121 (-5%)	16,400
FPC:constructor	94.8 (+1%)	9,304
GasToken:mint_public	83.7 (+3%)	6,150
Token:mint_public	92.2 (-1%)	11,720
Token:assert_minter_and_mint	⚠️ 84.3 (+49%)	8,028
AuthRegistry:set_authorized	⚠️ 13.1 (+44%)	4,537
FPC:prepare_fee	277 (+3%)	8,812
Token:transfer_public	⚠️ 69.3 (+107%)	32,641
FPC:pay_refund	96.8 (+29%)	12,114
Benchmarking:increment_balance	990	7,450
Token:_increase_public_balance	⚠️ 59.3 (+367%)	8,960
FPC:pay_refund_with_shielded_rebate	146 (-1%)	12,663

Public DB Access

Time to access various public DBs.

Function	time_ms
get-nullifier-index	0.155 (+3%)

Tree insertion stats

The duration to insert a fixed batch of leaves into each tree type.

Metric	1 leaves	16 leaves	64 leaves	128 leaves	256 leaves	512 leaves	1024 leaves
batch_insert_into_append_only_tree_16_depth_ms	10.1 (-1%)	16.5	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_count	16.8	31.7	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_ms	0.587 (-1%)	0.508 (+1%)	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_32_depth_ms	N/A	N/A	47.4	74.7 (+1%)	129	241	463 (+1%)
batch_insert_into_append_only_tree_32_depth_hash_count	N/A	N/A	95.9	159	287	543	1,055
batch_insert_into_append_only_tree_32_depth_hash_ms	N/A	N/A	0.484	0.459 (+1%)	0.444	0.437	0.433 (+1%)
batch_insert_into_indexed_tree_20_depth_ms	N/A	N/A	58.6	109 (-2%)	180 (+1%)	347 (-1%)	682 (+1%)
batch_insert_into_indexed_tree_20_depth_hash_count	N/A	N/A	109	207	355	691	1,363
batch_insert_into_indexed_tree_20_depth_hash_ms	N/A	N/A	0.495	0.492 (-1%)	0.478 (+1%)	0.471	0.470 (+1%)
batch_insert_into_indexed_tree_40_depth_ms	N/A	N/A	71.8	N/A	N/A	N/A	N/A
batch_insert_into_indexed_tree_40_depth_hash_count	N/A	N/A	133	N/A	N/A	N/A	N/A
batch_insert_into_indexed_tree_40_depth_hash_ms	N/A	N/A	0.511	N/A	N/A	N/A	N/A

Miscellaneous

Transaction sizes based on how many contract classes are registered in the tx.

Metric	0 registered classes	1 registered classes
tx_size_in_bytes	59,093	663,472

Transaction size based on fee payment method

| Metric | |
| - | |