Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sumcheck verification failure related to pedersen_commitment(...) func #7738

Closed
benesjan opened this issue Aug 2, 2024 · 1 comment
Closed

Comments

@benesjan
Copy link
Contributor

benesjan commented Aug 2, 2024

Using pedersen_commitment in compute_note_hiding_point(...) func results in prover test failing with Sumcheck verification failed.

image

To reproduce this error look for TODO(#7738) in the codebase and nuke the manually implemented function such that the one from macros gets used. Then the prover tests should fail again.

Look for pedersen_commitment in note_interface.rs file to see where the problematic func gets generated.

@benesjan
Copy link
Contributor Author

benesjan commented Oct 4, 2024

Stale issue

@benesjan benesjan closed this as completed Oct 4, 2024
@github-project-automation github-project-automation bot moved this from Todo to Done in A3 Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

1 participant