Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove superfluous call to MSM when computing note hiding point #7551

Closed
benesjan opened this issue Jul 22, 2024 · 0 comments · Fixed by #7708
Closed

Remove superfluous call to MSM when computing note hiding point #7551

benesjan opened this issue Jul 22, 2024 · 0 comments · Fixed by #7708
Assignees
@benesjan

Comments

@benesjan
Copy link
Contributor

benesjan commented Jul 22, 2024 •
edited
Loading

Due to pedersen_committment not working with AVM I introduced a hack in the compute_note_hiding_point. Remove this hack once the pedersen_commitment function is ready in the AVM.

Look for TODO(#7551) in the codebase.
@github-project-automation github-project-automation bot moved this to Todo in A3 Jul 22, 2024
@benesjan benesjan mentioned this issue Jul 23, 2024
Closed
@benesjan benesjan changed the title Do clean up and fix naming issues introduced with the storage slot as point scheme Do a clean-up and fix naming issues introduced with the storage slot as point scheme Jul 23, 2024
@benesjan benesjan changed the title Do a clean-up and fix naming issues introduced with the storage slot as point scheme Remove superfluous call to MSM when computing note hiding point Jul 30, 2024
@benesjan benesjan self-assigned this Jul 30, 2024
@benesjan benesjan mentioned this issue Aug 1, 2024
Merged
@github-project-automation github-project-automation bot moved this from Todo to Done in A3 Aug 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@benesjan benesjan

Labels
None yet
Projects
A3
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: removing superfluous call to MSM AztecProtocol/aztec-packages
1 participant
@benesjan