chore: all hashes in ts

[charlielye]

This is mostly just removing a bunch of async/await stuff as we convert the final 3 functions in abis.ts to use foundation/crypto/pedersen.

There are two things that are iffy, but not sure if that should block a merge as everything passes:

• vkHash, I've hardcoded a couple of values I don't fully understand (coset generator and root, which are pulled from evalutation domain in the C++).
• computePublicCallStackItemHash the C++ did something funky when isExecutionRequest is true. I don't fully understand what and if it needs reproducing here, but again, everything passes.

Have left the commented C++ code in the two places above for reference.

[AztecBot]

Benchmark results

No metrics with a significant change found.

Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Values are compared against data from master at commit 48d8c7fd and shown if the difference exceeds 1%.

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric	8 txs	32 txs	128 txs
l1_rollup_calldata_size_in_bytes	45,444	179,588	716,132
l1_rollup_calldata_gas	223,008	868,220	3,449,576
l1_rollup_execution_gas	842,095	3,595,328	22,204,945
l2_block_processing_time_in_ms	2,047 (+2%)	7,629	30,214 (+1%)
note_successful_decrypting_time_in_ms	293	874 (+1%)	3,196 (+1%)
note_trial_decrypting_time_in_ms	95.9 (+3%)	82.0 (+12%)	132 (-2%)
l2_block_building_time_in_ms	20,545	81,618	326,072
l2_block_rollup_simulation_time_in_ms	11,944	47,366 (-1%)	188,397
l2_block_public_tx_process_time_in_ms	8,555	34,119	137,179 (+1%)

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 16 txs.

Metric	5 blocks	10 blocks
node_history_sync_time_in_ms	21,886 (+1%)	42,796
note_history_successful_decrypting_time_in_ms	2,025 (-1%)	4,077
note_history_trial_decrypting_time_in_ms	121 (+1%)	145 (-18%)
node_database_size_in_bytes	1,629,170	1,099,493
pxe_database_size_in_bytes	29,748	59,307

Circuits stats

Stats on running time and I/O sizes collected for every circuit run across all benchmarks.

Circuit	circuit_simulation_time_in_ms	circuit_input_size_in_bytes	circuit_output_size_in_bytes
private-kernel-init	764	61,697	18,905
private-kernel-ordering	125	24,297	8,153
base-rollup	1,771	656,428	873
root-rollup	168 (-1%)	4,072	1,097
private-kernel-inner	788 (+1%)	81,568	18,905
public-kernel-private-input	568	41,519	18,905
public-kernel-non-first-iteration	406	41,561	18,905
merge-rollup	15.2	2,592	873

Miscellaneous

Transaction sizes based on how many contracts are deployed in the tx.

Metric	0 deployed contracts	1 deployed contracts
tx_size_in_bytes	8,787	27,547

[charlielye]

This PR was meant to be a lot smaller, but it looks like: #3345 got accidentaly merged into it early.

[socket-security]

Removed dependencies detected. Learn more about Socket for GitHub ↗︎

🚮 Removed packages: @rushstack/[email protected]

[ludamad]

This PR was meant to be a lot smaller, but it looks like: #3345 got accidentaly merged into it early.

My bad!

[charlielye]

Started getting weird conflicts so I just merged downstream #3345 into this as well. So this is become a mega PR :/
You can view the two merged PR's to see those changes in isolation. To see this specific PR's changes in isolation ignoring the downstream merges will probably require a bit of manual git diff.