fix: noir-compiler breadth-first resolver

[alexghr]

This PR fixes an issue hit by @spypsy and @catmcgee last week while working on a sample contract. They were not able to compile their contract because the compiler failed to find all of the needed dependencies.

I've identified the issue with NoirDependencyManager resolving dependencies in a depth-first manner. This caused issues with libraries that had dependencies of their own linked to by relative paths. This was a problem because the new pipeline using wasm only unpacks the required folder from a github archive (while Nargo gets the whole thing). In the contract's case, it had dependencies on easy_private_state and value_note (in this order) but easy_private_state needed value_note to exist before the manager resolved it.

This PR replaces the algorithm with a breadth-first resolver which fixes this. It also adds updates the existing unit test for the manager to check this edge case.

[AztecBot]

Benchmark results

Metrics with a significant change:

• note_trial_decrypting_time_in_ms (8): 3.15 (-97%)

Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Values are compared against data from master at commit 4623d916 and shown if the difference exceeds 1%.

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric	8 txs	32 txs	128 txs
l1_rollup_calldata_size_in_bytes	45,444	179,588	716,132
l1_rollup_calldata_gas	222,984	867,380	3,447,788
l1_rollup_execution_gas	842,071	3,594,488	22,203,157
l2_block_processing_time_in_ms	2,007 (+1%)	7,579	29,768
note_successful_decrypting_time_in_ms	299 (+2%)	867	3,164
note_trial_decrypting_time_in_ms	⚠️ 3.15 (-97%)	76.8 (+2%)	134 (+1%)
l2_block_building_time_in_ms	13,468 (+2%)	52,705 (+1%)	210,397 (+1%)
l2_block_rollup_simulation_time_in_ms	12,105 (+2%)	47,414 (+1%)	189,330 (+1%)
l2_block_public_tx_process_time_in_ms	1,317	5,154	20,564 (+1%)

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 16 txs.

Metric	5 blocks	10 blocks
node_history_sync_time_in_ms	21,705	42,394 (-1%)
note_history_successful_decrypting_time_in_ms	2,027	3,942 (-2%)
note_history_trial_decrypting_time_in_ms	121	143 (-19%)
node_database_size_in_bytes	1,631,768	1,099,849
pxe_database_size_in_bytes	29,748	59,307

Circuits stats

Stats on running time and I/O sizes collected for every circuit run across all benchmarks.

Circuit	circuit_simulation_time_in_ms	circuit_input_size_in_bytes	circuit_output_size_in_bytes
private-kernel-init	763	61,697	18,905
private-kernel-ordering	125 (-1%)	24,297	8,153
base-rollup	1,770	656,311	814
root-rollup	168 (-1%)	4,072	1,097
private-kernel-inner	787	81,568	18,905
public-kernel-private-input	41.1	41,519	18,841
public-kernel-non-first-iteration	25.8	41,497	18,841
merge-rollup	15.1 (-1%)	2,592	873

Miscellaneous

Transaction sizes based on how many contracts are deployed in the tx.

Metric	0 deployed contracts	1 deployed contracts
tx_size_in_bytes	8,787	27,547