Skip to content

Commit

Permalink
feat: Open transcript polys as univariates in ECCVM (#3331)
Browse files Browse the repository at this point in the history
The ECCVM must prove univariate openings for the 5 transcript
polynomials so that the evaluations can be checked by the translator.
This will likely change somewhat once the ECCVM is updated to use
Zeromorph.
  • Loading branch information
ledwards2225 authored Nov 17, 2023
1 parent 5a18615 commit 436b22e
Show file tree
Hide file tree
Showing 3 changed files with 183 additions and 112 deletions.
57 changes: 57 additions & 0 deletions barretenberg/cpp/src/barretenberg/eccvm/eccvm_prover.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -303,6 +303,61 @@ template <ECCVMFlavor Flavor> void ECCVMProver_<Flavor>::execute_final_pcs_round
PCS::compute_opening_proof(commitment_key, shplonk_output.opening_pair, shplonk_output.witness, transcript);
}

/**
* @brief Batch open the transcript polynomials as univariates for Translator consistency check
* TODO(#768): Find a better way to do this. See issue for details.
*
* @tparam Flavor
*/
template <ECCVMFlavor Flavor> void ECCVMProver_<Flavor>::execute_transcript_consistency_univariate_opening_round()
{
// Since IPA cannot currently handle polynomials for which the latter half of the coefficients are 0, we hackily
// batch the constant polynomial 1 in with the 5 transcript polynomials. See issue #768 for more details.
Polynomial hack(key->circuit_size);
for (size_t idx = 0; idx < key->circuit_size; idx++) {
hack[idx] = 1;
}
transcript.send_to_verifier("Translation:hack_commitment", commitment_key->commit(hack));

// Get the challenge at which we evaluate the polynomials as univariates
FF evaluation_challenge_x = transcript.get_challenge("Translation:evaluation_challenge_x");

// Collect the polynomials and evaluations to be batched
const size_t NUM_UNIVARIATES = 6; // 5 transcript polynomials plus the constant hack poly
std::array<Polynomial, NUM_UNIVARIATES> univariate_polynomials = { key->transcript_op, key->transcript_Px,

This comment has been minimized.

Copy link
@codygunton

codygunton Nov 17, 2023

Contributor

Went a little fast reviewing here: I think this will do a needless copy, won't it?

key->transcript_Py, key->transcript_z1,
key->transcript_z2, hack };
std::array<FF, NUM_UNIVARIATES> univariate_evaluations;
for (auto [eval, polynomial] : zip_view(univariate_evaluations, univariate_polynomials)) {
eval = polynomial.evaluate(evaluation_challenge_x);
}

// Add the univariate evaluations to the transcript
transcript.send_to_verifier("Translation:op", univariate_evaluations[0]);
transcript.send_to_verifier("Translation:Px", univariate_evaluations[1]);
transcript.send_to_verifier("Translation:Py", univariate_evaluations[2]);
transcript.send_to_verifier("Translation:z1", univariate_evaluations[3]);
transcript.send_to_verifier("Translation:z2", univariate_evaluations[4]);
transcript.send_to_verifier("Translation:hack_evaluation", univariate_evaluations[5]);

// Get another challenge for batching the univariate claims
FF batching_challenge = transcript.get_challenge("Translation:batching_challenge");

// Constuct the batched polynomial and batched evaluation
Polynomial batched_univariate{ key->circuit_size };
FF batched_evaluation{ 0 };
auto batching_scalar = FF(1);
for (auto [eval, polynomial] : zip_view(univariate_evaluations, univariate_polynomials)) {
batched_univariate.add_scaled(polynomial, batching_scalar);
batched_evaluation += eval * batching_scalar;
batching_scalar *= batching_challenge;
}

// Compute a proof for the batched univariate opening
PCS::compute_opening_proof(
commitment_key, { evaluation_challenge_x, batched_evaluation }, batched_univariate, transcript);
}

template <ECCVMFlavor Flavor> plonk::proof& ECCVMProver_<Flavor>::export_proof()
{
proof.proof_data = transcript.proof_data;
Expand Down Expand Up @@ -331,6 +386,8 @@ template <ECCVMFlavor Flavor> plonk::proof& ECCVMProver_<Flavor>::construct_proo

execute_final_pcs_round();

execute_transcript_consistency_univariate_opening_round();

return export_proof();
}

Expand Down
1 change: 1 addition & 0 deletions barretenberg/cpp/src/barretenberg/eccvm/eccvm_prover.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@ template <ECCVMFlavor Flavor> class ECCVMProver_ {
void execute_shplonk_batched_quotient_round();
void execute_shplonk_partial_evaluation_round();
void execute_final_pcs_round();
void execute_transcript_consistency_univariate_opening_round();

plonk::proof& export_proof();
plonk::proof& construct_proof();
Expand Down
Loading

0 comments on commit 436b22e

Please sign in to comment.