-
Notifications
You must be signed in to change notification settings - Fork 268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle forks (different aztec version) in Inbox/outbox/registry #624
Comments
6 tasks
6 tasks
LHerskind
added a commit
that referenced
this issue
Jul 29, 2023
# Description Fixes #359 and #624. # Checklist: - [ ] I have reviewed my diff in github, line by line. - [ ] Every change is related to the PR description. - [ ] I have [linked](https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue) this pull request to the issue(s) that it resolves. - [ ] There are no unexpected formatting changes, superfluous debug logs, or commented-out code. - [ ] The branch has been merged or rebased against the head of its merge target. - [ ] I'm happy for the PR to be merged at the reviewer's next convenience.
LHerskind
added a commit
that referenced
this issue
Jul 30, 2023
# Description Fixes #359 and #624. # Checklist: - [ ] I have reviewed my diff in github, line by line. - [ ] Every change is related to the PR description. - [ ] I have [linked](https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue) this pull request to the issue(s) that it resolves. - [ ] There are no unexpected formatting changes, superfluous debug logs, or commented-out code. - [ ] The branch has been merged or rebased against the head of its merge target. - [ ] I'm happy for the PR to be merged at the reviewer's next convenience.
Was closed by #1245 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently the inbox, outbox simply call the latest version of the rollup. Similarly the rollup posts/consumes messages only from the latest version of the inbox/outbox. This won't work for different aztec versions.
Storing version in these contracts also doesn't work because what if an Outbox is used for multiple contracts.
Changes are also expected in the portal contracts and the L1<>L2 e2e test
The text was updated successfully, but these errors were encountered: