fix: replace force insert in TS #643
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LHerskind
force-pushed
the
lh/613-replace-force-insertion
branch
from
6922b36 to
19850ab
Compare
Maddiaa0
reviewed
May 22, 2023
Maddiaa0
reviewed
May 22, 2023
| // getting the 32 byte hex string representation of the content | ||
| const contentString: `0x{String}` = `0x${content.toBuffer().toString('hex')}` as `0x{String}`; | ||
| // Using the 0 value for the secretHash. | ||
| const zeroString: `0x{String}` = `0x${fr(0).toBuffer().toString('hex')}` as `0x{String}`; |
There was a problem hiding this comment.
fr(0) -> Fr.ZERO
Also rename var to secretHash?
| }; | ||
|
|
||
| it(`Build ${numberOfConsecutiveBlocks} blocks of 4 bloated txs building on each other`, async () => { | ||
| const stateInRollup_ = await rollup.read.rollupStateHash(); | ||
| expect(hexStringToBuffer(stateInRollup_.toString())).toEqual(Buffer.alloc(32, 0)); | ||
|
|
||
| const blockNumber = await publicClient.getBlockNumber(); | ||
| const recipientAddress = AztecAddress.fromString( | ||
| '0x1647b194c649f5dd01d7c832f89b0f496043c9150797923ea89e93d5ac619a93', |
There was a problem hiding this comment.
where is this from? maybe leave a comment?
| expect(inboxLogs).toHaveLength(l1ToL2Messages.length * (i + 1)); | ||
| for (let j = 0; j < NUMBER_OF_L1_L2_MESSAGES_PER_ROLLUP; j++) { | ||
| const event = inboxLogs[j + i * NUMBER_OF_L1_L2_MESSAGES_PER_ROLLUP].args; | ||
| expect(event.content).toEqual(`0x${l1ToL2Content[j].toBuffer().toString('hex')}`); |
There was a problem hiding this comment.
Interesting i would expect .toString('hex') to automatically add 0x
LHerskind
force-pushed
the
lh/613-replace-force-insertion
branch
from
9de5254 to
d756d1f
Compare
Maddiaa0
approved these changes
May 23, 2023
rahul-kothari
approved these changes
May 23, 2023
This was referenced Jul 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #613 and #630.
typescriptimplementation of force insertion into inboxsolidityimplementation of force insertion into inboxChecklist: