Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix #526 - add upgrade mechanism to registry #625

Merged
merged 4 commits into from
May 23, 2023
Merged

fix #526 - add upgrade mechanism to registry #625

merged 4 commits into from
May 23, 2023

Conversation

rahul-kothari
Copy link
Contributor

@rahul-kothari rahul-kothari commented May 19, 2023 •
edited
Loading

Description

Per our slack discussion of registry snapshotting issue, currently, rollup/inbox/outbox just call the latest version of each other. So we aren't really handling forks for now. I have therefore created #624 for when we reach consensus on how to handle forks for L1<>L2 communication.

Fixes #526

Checklist:

  • I have reviewed my diff in github, line by line.
  • Every change is related to the PR description.
  • I have linked this pull request to the issue(s) that it resolves.
  • There are no unexpected formatting changes, superfluous debug logs, or commented-out code.
  • The branch has been merged or rebased against the head of its merge target.
  • I'm happy for the PR to be merged at the reviewer's next convenience.

@rahul-kothari rahul-kothari requested a review from LHerskind May 19, 2023 10:11
LHerskind
LHerskind reviewed May 19, 2023
View reviewed changes
Copy link
Contributor

@LHerskind LHerskind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nits on naming.

l1-contracts/src/core/Rollup.sol Show resolved Hide resolved
l1-contracts/src/core/libraries/DataStructures.sol Outdated Show resolved Hide resolved
l1-contracts/src/core/messagebridge/Inbox.sol Outdated Show resolved Hide resolved
l1-contracts/src/core/messagebridge/Registry.sol Outdated Show resolved Hide resolved
@rahul-kothari rahul-kothari requested a review from LHerskind May 22, 2023 14:23
LHerskind
LHerskind reviewed May 22, 2023
View reviewed changes
Copy link
Contributor

@LHerskind LHerskind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs some natspec for all the functions in Registry

l1-contracts/src/core/messagebridge/Registry.sol Outdated Show resolved Hide resolved
l1-contracts/src/core/messagebridge/Registry.sol Outdated Show resolved Hide resolved
l1-contracts/src/core/messagebridge/Registry.sol Outdated Show resolved Hide resolved
@rahul-kothari rahul-kothari requested a review from LHerskind May 22, 2023 16:03
LHerskind
LHerskind approved these changes May 22, 2023
View reviewed changes
Copy link
Contributor

@LHerskind LHerskind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More consistency on @notice then good to go.

@rahul-kothari rahul-kothari merged commit 3555337 into master May 23, 2023
@rahul-kothari rahul-kothari deleted the rk/registry branch May 23, 2023 08:50
This was referenced Jul 25, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LHerskind LHerskind LHerskind approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add upgrade function to registry
2 participants
@rahul-kothari @LHerskind