-
Notifications
You must be signed in to change notification settings - Fork 265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
L1 <> L2 messages need to be scoped to a particular version of Aztec #359
Comments
Currently the implementation is assuming one rollup due to the upcoming upgrade RFP this have not been changed yet, as it depends on the mechanism chosen. |
ludamad
pushed a commit
that referenced
this issue
Jul 14, 2023
* lookup grand product relation tests passing * ignore final entry in table polys for consistency chec, same reason as for selectors * adding eta and lookup gp delta to relation params * incorporate lookup gp init relation into tests * correcting the degree of lookup relation
Idea to limit based on versioning that is enforced fully on L1 (no circuit changes).
|
6 tasks
LHerskind
added a commit
that referenced
this issue
Jul 29, 2023
# Description Fixes #359 and #624. # Checklist: - [ ] I have reviewed my diff in github, line by line. - [ ] Every change is related to the PR description. - [ ] I have [linked](https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue) this pull request to the issue(s) that it resolves. - [ ] There are no unexpected formatting changes, superfluous debug logs, or commented-out code. - [ ] The branch has been merged or rebased against the head of its merge target. - [ ] I'm happy for the PR to be merged at the reviewer's next convenience.
LHerskind
added a commit
that referenced
this issue
Jul 30, 2023
# Description Fixes #359 and #624. # Checklist: - [ ] I have reviewed my diff in github, line by line. - [ ] Every change is related to the PR description. - [ ] I have [linked](https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue) this pull request to the issue(s) that it resolves. - [ ] There are no unexpected formatting changes, superfluous debug logs, or commented-out code. - [ ] The branch has been merged or rebased against the head of its merge target. - [ ] I'm happy for the PR to be merged at the reviewer's next convenience.
codygunton
pushed a commit
that referenced
this issue
Jan 23, 2024
* lookup grand product relation tests passing * ignore final entry in table polys for consistency chec, same reason as for selectors * adding eta and lookup gp delta to relation params * incorporate lookup gp init relation into tests * correcting the degree of lookup relation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Portal contracts need to define which version of Aztec, they can consume messages from.
Example
Lets say a portal contract manages Dai deposits. A user deposits 1,000 Dai to the portal contract that adds a message to the L1 > L2 Message Box.
The rollup implementation is then upgraded to support a less secure hash function / or some other change the user / dApp developer does not agree with.
In order to protect against the message being consumed in the newer version, the message needs to be scoped to a version.
The text was updated successfully, but these errors were encountered: