Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Carousel: add more specific selectors for the carousel cursor #20882

Merged
merged 1 commit into from
Aug 31, 2021
Merged

Carousel: add more specific selectors for the carousel cursor #20882

merged 1 commit into from
Aug 31, 2021

Conversation

kbrown9
Copy link
Member

@kbrown9 kbrown9 commented Aug 31, 2021 •
edited
Loading

Changes proposed in this Pull Request:

  • The cursor should only change to a pointer when over an img or a figcaption that is the sibling of an img.

I'm not sure if this change adequately covers all situations where images can be opened in the carousel. If you know any other situations that should be tested (maybe galleries from other plugins?), please let me know.

I'm suggesting this as a possible temporary solution to the issue reported in #13428, until we have a better solution for gallery parsing.

Jetpack product discussion

  • n/a

Does this pull request change what data or activity we track or use?

  • no

Testing instructions:

Reproduce the Bug
  1. Install, activate, and connect the master branch of Jetpack.
  2. In wp-admin, navigate to Jetpack -> Settings -> Writing. Enable the Display images in a full-screen carousel gallery setting. It's in the Media section, at the top.
  3. Create a new post to test the Gallery block:
    a. Add a Gallery block with some images.
    b. Add a columns block with a couple of columns. Add some paragraph blocks in the columns.
  4. Visit the post with the Gallery block. Mouse over the test in the columns and notice that the cursor changes to a pointer.
  5. Create a new post to test the Tiled Gallery block:
    a. Add a Tiled Gallery block with some images.
    b. Add a columns block with a couple of columns. Add some paragraph blocks in the columns.
  6. Visit the post with the Gallery block. Mouse over the test in the columns and notice that the cursor changes to a pointer.

Test this PR

  1. Switch to this branch of Jetpack
  2. Visit the post with the Gallery block. Mouse over the test in the columns and notice that the cursor does not change to a pointer.
  3. Visit the post with the Tiled Gallery block. Mouse over the test in the columns and notice that the cursor does not change to a pointer.

@kbrown9
Carousel: add more specific selectors for the carousel cursor
806a82d 
The cursor should only change to a pointer when over an img or a figcaption that is
the sibling of an img.
@kbrown9 kbrown9 self-assigned this Aug 31, 2021
@matticbot
Copy link
Contributor

Caution: This PR has changes that must be merged to WordPress.com
Hello kbrown9! These changes need to be synced to WordPress.com - If you 're an a11n, please commandeer and confirm D66104-code works as expected before merging this PR. Once this PR is merged, please commit the changes to WP.com. Thank you!
This revision will be updated with each commit to this PR

@github-actions github-actions bot added [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Feature] Carousel A fullscreen modal appearing when clicking on an image in a gallery or tiled gallery. labels Aug 31, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Aug 31, 2021 •
edited
Loading

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ All commits were linted before commit.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.

Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team review" label and ask someone from your team review the code.
Once you’ve done so, switch to the "[Status] Needs Review" label; someone from Jetpack Crew will then review this PR and merge it to be included in the next Jetpack release.

Jetpack plugin:

  • Next scheduled release: September 7, 2021.
  • Scheduled code freeze: August 30, 2021.

@github-actions github-actions bot added the [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! label Aug 31, 2021
@kbrown9 kbrown9 added [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. and removed [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! labels Aug 31, 2021
@kbrown9 kbrown9 added this to the jetpack/10.1 milestone Aug 31, 2021
@jeherve jeherve added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. labels Aug 31, 2021
jeherve
jeherve approved these changes Aug 31, 2021
View reviewed changes
Copy link
Member

@jeherve jeherve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This tests well for me. 🚢

@kbrown9 kbrown9 merged commit 50ae990 into master Aug 31, 2021
@kbrown9 kbrown9 deleted the update/carousel_cursor_css branch August 31, 2021 13:12
@github-actions
Copy link
Contributor

Great news! One last step: head over to your WordPress.com diff, D66104-code, and commit it.
Once you've done so, come back to this PR and add a comment with your changeset ID.

Thank you!

@kbrown9
Copy link
Member Author

kbrown9 commented Aug 31, 2021

Deployed to wpcom in r231008-wpcom.

This was referenced Aug 31, 2021
Closed
Merged
davidlonjon added a commit that referenced this pull request Sep 2, 2021
@davidlonjon
Merge branch 'master' into try/boost-javascript-tests-workflow
8386c67 
* master:
  tools: Tool to report unreleased projects (#20874)
  Add max length for stacktrace in Slack notifications (#20913)
  Show HLS Playlist for the VideoPress video url, instead of fragmented mp4 file (#20839)
  VideoPress: Fix VideoPress Attachment Deletions on wp.com (#20832)
  Update various JS dependencies (#20890)
  Widget Visibility: add scaffolding for upcoming editor features. (#20910)
  Heartbeat: Fix typo (#20901)
  Social Icons: fix being able to remove icons (#20899)
  Update To-Test.md for Jetpack 10.1 (#20894)
  Update dependency size-limit to v5 (#20893)
  Release: start 10.2 cycle (#20896)
  Jetpack 10.1 Changelog (#20892)
  E2E tests: add report name option in Slack notification (#20887)
  Carousel: add more specific selectors for the carousel cursor (#20882)
  E2E Tests: Fix pre-connection test (#20888)
  Search: fix body scroll for overlay open/close (#20733)
  E2E Tests: Fix mailchimp test (#20855)
  E2E tests: improve error handling (#20884)
@kraftbj kraftbj removed the [Status] Ready to Merge Go ahead, you can push that green button! label Sep 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeherve jeherve jeherve approved these changes

Assignees

@kbrown9 kbrown9

Labels
[Feature] Carousel A fullscreen modal appearing when clicking on an image in a gallery or tiled gallery. [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ Touches WP.com Files
Projects
None yet
Milestone
jetpack/10.1
Development

Successfully merging this pull request may close these issues.
4 participants
@kbrown9 @matticbot @jeherve @kraftbj