Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update To-Test.md for Jetpack 10.1 #20894

Merged
merged 4 commits into from
Aug 31, 2021
Merged

Update To-Test.md for Jetpack 10.1 #20894

merged 4 commits into from
Aug 31, 2021

Conversation

sdixon194
Copy link
Contributor

Changes proposed in this Pull Request:

  • Updates to-test.md file.

Jetpack product discussion

N/a

Does this pull request change what data or activity we track or use?

No

Testing instructions:

  • Proofread

@sdixon194 sdixon194 added the [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ label Aug 31, 2021
@sdixon194 sdixon194 requested a review from samiff August 31, 2021 17:43
@github-actions
Copy link
Contributor

github-actions bot commented Aug 31, 2021 •
edited
Loading

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ All commits were linted before commit.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.

Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team review" label and ask someone from your team review the code.
Once you’ve done so, switch to the "[Status] Needs Review" label; someone from Jetpack Crew will then review this PR and merge it to be included in the next Jetpack release.

Jetpack plugin:

  • Next scheduled release: September 7, 2021.
  • Scheduled code freeze: August 30, 2021.

@github-actions github-actions bot added the [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! label Aug 31, 2021
@sdixon194 sdixon194 added [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. and removed [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! labels Aug 31, 2021
jeherve
jeherve approved these changes Aug 31, 2021
View reviewed changes
Copy link
Member

@jeherve jeherve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. 🚢

@jeherve jeherve added [Status] Ready to Merge Go ahead, you can push that green button! [Type] Janitorial and removed [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. labels Aug 31, 2021
@jeherve jeherve added this to the jetpack/10.1 milestone Aug 31, 2021
@sdixon194 sdixon194 enabled auto-merge (squash) August 31, 2021 18:07
@sdixon194 sdixon194 merged commit 61fc1f8 into master Aug 31, 2021
@sdixon194 sdixon194 deleted the add/10.1-to-test-instructions branch August 31, 2021 18:17
@github-actions github-actions bot removed the [Status] Ready to Merge Go ahead, you can push that green button! label Aug 31, 2021
davidlonjon added a commit that referenced this pull request Sep 2, 2021
@davidlonjon
Merge branch 'master' into try/boost-javascript-tests-workflow
8386c67 
* master:
  tools: Tool to report unreleased projects (#20874)
  Add max length for stacktrace in Slack notifications (#20913)
  Show HLS Playlist for the VideoPress video url, instead of fragmented mp4 file (#20839)
  VideoPress: Fix VideoPress Attachment Deletions on wp.com (#20832)
  Update various JS dependencies (#20890)
  Widget Visibility: add scaffolding for upcoming editor features. (#20910)
  Heartbeat: Fix typo (#20901)
  Social Icons: fix being able to remove icons (#20899)
  Update To-Test.md for Jetpack 10.1 (#20894)
  Update dependency size-limit to v5 (#20893)
  Release: start 10.2 cycle (#20896)
  Jetpack 10.1 Changelog (#20892)
  E2E tests: add report name option in Slack notification (#20887)
  Carousel: add more specific selectors for the carousel cursor (#20882)
  E2E Tests: Fix pre-connection test (#20888)
  Search: fix body scroll for overlay open/close (#20733)
  E2E Tests: Fix mailchimp test (#20855)
  E2E tests: improve error handling (#20884)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeherve jeherve jeherve approved these changes

@samiff samiff Awaiting requested review from samiff

Assignees

@sdixon194 sdixon194

Labels
[Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Type] Janitorial
Projects
None yet
Milestone
jetpack/10.1
Development

Successfully merging this pull request may close these issues.
2 participants
@sdixon194 @jeherve