Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Widget Visibility: add scaffolding for upcoming editor features. #20910

Merged
merged 1 commit into from
Sep 1, 2021
Merged

Widget Visibility: add scaffolding for upcoming editor features. #20910

merged 1 commit into from
Sep 1, 2021

Conversation

jeherve
Copy link
Member

@jeherve jeherve commented Sep 1, 2021

Changes proposed in this Pull Request:


This does not much on its own, but is the first step to allow us to ship #20731.

This will also allow us to get Jetpack and WordPress.com Simple in sync, for easier merges and changes in the future.

Jetpack product discussion

  • pbAok1-2dI-p2

Does this pull request change what data or activity we track or use?

  • No

Testing instructions:

  • Is CI happy?

@jeherve
Widget Visibility: add scaffolding for upcoming editor features.
5f3c614 
This does not much on its own, but is the first step to allow us to ship #20731.
@jeherve jeherve added [Feature] Widget Visibility [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. [Type] Janitorial [Type] Feature Request [Pri] Normal labels Sep 1, 2021
@jeherve jeherve added this to the jetpack/10.2 milestone Sep 1, 2021
@jeherve jeherve self-assigned this Sep 1, 2021
@github-actions github-actions bot added the [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ label Sep 1, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Sep 1, 2021 •
edited
Loading

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ All commits were linted before commit.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.

Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team review" label and ask someone from your team review the code.
Once you’ve done so, switch to the "[Status] Needs Review" label; someone from Jetpack Crew will then review this PR and merge it to be included in the next Jetpack release.

Jetpack plugin:

  • Next scheduled release: September 7, 2021.
  • Scheduled code freeze: August 30, 2021.

@matticbot
Copy link
Contributor

Caution: This PR has changes that must be merged to WordPress.com
Hello jeherve! These changes need to be synced to WordPress.com - If you 're an a11n, please commandeer and confirm D66167-code works as expected before merging this PR. Once this PR is merged, please commit the changes to WP.com. Thank you!
This revision will be updated with each commit to this PR

@jeherve
Copy link
Member Author

jeherve commented Sep 1, 2021

r231054-wpcom

@jeherve jeherve mentioned this pull request Sep 1, 2021
Merged
@jeherve jeherve enabled auto-merge (squash) September 1, 2021 12:02
anomiex
anomiex approved these changes Sep 1, 2021
View reviewed changes
Copy link
Contributor

@anomiex anomiex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI looks happy. Let's go ahead with this to get things back in sync.

projects/plugins/jetpack/modules/widget-visibility/editor/README.md Show resolved Hide resolved
@jeherve jeherve merged commit 1bfe6f5 into master Sep 1, 2021
@jeherve jeherve deleted the add/scaffolding-widget-visibilty-block-editor branch September 1, 2021 13:15
@github-actions
Copy link
Contributor

github-actions bot commented Sep 1, 2021

Great news! One last step: head over to your WordPress.com diff, D66167-code, and commit it.
Once you've done so, come back to this PR and add a comment with your changeset ID.

Thank you!

@github-actions github-actions bot removed the [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. label Sep 1, 2021
@jeherve jeherve mentioned this pull request Sep 2, 2021
Merged
jeherve pushed a commit that referenced this pull request Sep 2, 2021
@anomiex @jeherve
Widget Visibility build tools: adjust command in readme
eaff03a 
See #20910 (comment)
davidlonjon added a commit that referenced this pull request Sep 2, 2021
@davidlonjon
Merge branch 'master' into try/boost-javascript-tests-workflow
8386c67 
* master:
  tools: Tool to report unreleased projects (#20874)
  Add max length for stacktrace in Slack notifications (#20913)
  Show HLS Playlist for the VideoPress video url, instead of fragmented mp4 file (#20839)
  VideoPress: Fix VideoPress Attachment Deletions on wp.com (#20832)
  Update various JS dependencies (#20890)
  Widget Visibility: add scaffolding for upcoming editor features. (#20910)
  Heartbeat: Fix typo (#20901)
  Social Icons: fix being able to remove icons (#20899)
  Update To-Test.md for Jetpack 10.1 (#20894)
  Update dependency size-limit to v5 (#20893)
  Release: start 10.2 cycle (#20896)
  Jetpack 10.1 Changelog (#20892)
  E2E tests: add report name option in Slack notification (#20887)
  Carousel: add more specific selectors for the carousel cursor (#20882)
  E2E Tests: Fix pre-connection test (#20888)
  Search: fix body scroll for overlay open/close (#20733)
  E2E Tests: Fix mailchimp test (#20855)
  E2E tests: improve error handling (#20884)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anomiex anomiex anomiex approved these changes

Assignees

@jeherve jeherve

Labels
[Feature] Widget Visibility [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Pri] Normal Touches WP.com Files [Type] Feature Request [Type] Janitorial
Projects
None yet
Milestone
jetpack/10.2
Development

Successfully merging this pull request may close these issues.
3 participants
@jeherve @matticbot @anomiex