Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Carousel: Fix cursor css selector #20927

Merged
merged 2 commits into from
Sep 3, 2021
Merged

Carousel: Fix cursor css selector #20927

merged 2 commits into from
Sep 3, 2021

Conversation

kbrown9
Copy link
Member

@kbrown9 kbrown9 commented Sep 2, 2021 •
edited
Loading

Changes proposed in this Pull Request:

Jetpack product discussion

  • p8oabR-IS-p2#comment-5462

Does this pull request change what data or activity we track or use?

  • no

Testing instructions:

This PR fixes a problem that occurs when the Carousel feature is disabled.

Set up the site
  1. Install, activate, and connect the release candidate of Jetpack version 10.1.
  2. Create a post with a Gallery block.
    a. Make sure to add multiple images and make sure that the images have captions.
    b. Add a Columns block. In each column, add something like a paragraph block with some text.
  3. Create a post with a Tiled Gallery block.
    a. Make sure to add multiple images.
    b. Add a Columns block. In each column, add something like a paragraph block with some text.
Reproduce the problem
  1. Verify that the Carousel feature is not enabled. In wp-admin, navigate to Jetpack -> Settings -> Writing. In the media section, the "Create full-screen carousel slideshows..." setting must be disabled.
  2. On the front end of the site, open the post with the Gallery block. Mouse over the image captions and notice that the cursor turns into a pointer. This shouldn't happen.
Test the fix
  1. Switch to this branch of Jetpack.
  2. On the front end of the site, open the post with the Gallery block. Mouse over the image captions and notice that the cursor doesn't turn into a pointer.
Test with the Carousel feature enabled
  1. Enable the Carousel feature. In wp-admin, navigate to Jetpack -> Settings -> Writing. In the media section, the "Create full-screen carousel slideshows..." setting must be enabled.
  2. On the front end of the site, open the post with the Gallery block. Mouse over the images and image captions and notice that the cursor turns into a pointer. Click the images and verify the the carousel opens.
  3. Mouse over the text in the columns block and verify that the cursor does not turn into a pointer.
  4. Repeat steps 9 through 11 on the post with the Tiled Gallery block.

@kbrown9 kbrown9 added [Type] Bug When a feature is broken and / or not performing as intended [Feature] Carousel A fullscreen modal appearing when clicking on an image in a gallery or tiled gallery. [Status] In Progress labels Sep 2, 2021
@kbrown9 kbrown9 self-assigned this Sep 2, 2021
@matticbot
Copy link
Contributor

Caution: This PR has changes that must be merged to WordPress.com
Hello kbrown9! These changes need to be synced to WordPress.com - If you 're an a11n, please commandeer and confirm D66261-code works as expected before merging this PR. Once this PR is merged, please commit the changes to WP.com. Thank you!
This revision will be updated with each commit to this PR

@github-actions github-actions bot added the [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ label Sep 2, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Sep 2, 2021 •
edited
Loading

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ All commits were linted before commit.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.

Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team review" label and ask someone from your team review the code.
Once you’ve done so, switch to the "[Status] Needs Review" label; someone from Jetpack Crew will then review this PR and merge it to be included in the next Jetpack release.

Jetpack plugin:

  • Next scheduled release: September 7, 2021.
  • Scheduled code freeze: August 30, 2021.

@kbrown9 kbrown9 added [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. [Status] Needs Cherry-Pick and removed [Status] In Progress labels Sep 2, 2021
@kbrown9 kbrown9 added this to the jetpack/10.1 milestone Sep 2, 2021
@jeherve jeherve added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. labels Sep 2, 2021
@sdixon194 sdixon194 merged commit a0cac8d into master Sep 3, 2021
@sdixon194 sdixon194 deleted the update/carousel_css_fix branch September 3, 2021 14:50
sdixon194 added a commit that referenced this pull request Sep 3, 2021
@kbrown9 @sdixon194
[not verified] Carousel: Fix cursor css selector (#20927)
944728d 
Co-authored-by: sdixon194 <[email protected]>
@sdixon194
Copy link
Contributor

Cherry picked to release branch in 944728d

@github-actions github-actions bot removed the [Status] Ready to Merge Go ahead, you can push that green button! label Sep 3, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Sep 3, 2021

Great news! One last step: head over to your WordPress.com diff, D66261-code, and commit it.
Once you've done so, come back to this PR and add a comment with your changeset ID.

Thank you!

@kbrown9
Copy link
Member Author

kbrown9 commented Sep 6, 2021

Deployed via r231314-wpcom

davidlonjon added a commit that referenced this pull request Sep 7, 2021
@davidlonjon
Merge branch 'master' into improve/add-more-context-to-api-fetch-error
df5cff0 
* master:
  Widget Visibility: fix undefined property ref (#20967)
  Carousel: update prev/next nav button colors (#20940)
  E2E tests: mention users in Slack based on report name and branch name (#20964)
  Search: fix search admin page wrapping issue for ultra wide screens (#20962)
  Instant Search customization: use sentence case consistently (#20931)
  RP: Use all args for the filter (#20953)
  renovate: Fix config (#20952)
  Backport Sync and Heartbeat Changelog from Release (#20950)
  Update renovate config (#20917)
  Sync: Defensive coding against E_NOTICE (#20921)
  Carousel: Fix cursor css selector (#20927)
  Search: Improve style specificity for result highlights in Customberg (#20945)
  Contact Form: add filter to allow customizing email headers. (#20912)
  Blocks: fix HTML markup of buttons added to our blocks. (#20936)
davidlonjon added a commit that referenced this pull request Sep 7, 2021
@davidlonjon
Merge branch 'master' into try/boost-javascript-tests-workflow
c483329 
* master:
  Widget Visibility: fix undefined property ref (#20967)
  Carousel: update prev/next nav button colors (#20940)
  E2E tests: mention users in Slack based on report name and branch name (#20964)
  Search: fix search admin page wrapping issue for ultra wide screens (#20962)
  Instant Search customization: use sentence case consistently (#20931)
  RP: Use all args for the filter (#20953)
  renovate: Fix config (#20952)
  Backport Sync and Heartbeat Changelog from Release (#20950)
  Update renovate config (#20917)
  Sync: Defensive coding against E_NOTICE (#20921)
  Carousel: Fix cursor css selector (#20927)
  Search: Improve style specificity for result highlights in Customberg (#20945)
  Contact Form: add filter to allow customizing email headers. (#20912)
  Blocks: fix HTML markup of buttons added to our blocks. (#20936)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeherve jeherve jeherve approved these changes

Assignees

@kbrown9 kbrown9

Labels
[Feature] Carousel A fullscreen modal appearing when clicking on an image in a gallery or tiled gallery. [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ Touches WP.com Files [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Milestone
jetpack/10.1
Development

Successfully merging this pull request may close these issues.
4 participants
@kbrown9 @matticbot @sdixon194 @jeherve