E2E tests: mention users in Slack based on report name and branch name #20964
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
[Plugin] Jetpack
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped. Jetpack plugin:
|
adimoldovan
added
[Status] Needs Review
brbrr
approved these changes
Sep 6, 2021
github-actions
bot
removed
the
[Status] Needs Review
davidlonjon
added a commit
that referenced
this pull request
Sep 7, 2021
* master: Widget Visibility: fix undefined property ref (#20967) Carousel: update prev/next nav button colors (#20940) E2E tests: mention users in Slack based on report name and branch name (#20964) Search: fix search admin page wrapping issue for ultra wide screens (#20962) Instant Search customization: use sentence case consistently (#20931) RP: Use all args for the filter (#20953) renovate: Fix config (#20952) Backport Sync and Heartbeat Changelog from Release (#20950) Update renovate config (#20917) Sync: Defensive coding against E_NOTICE (#20921) Carousel: Fix cursor css selector (#20927) Search: Improve style specificity for result highlights in Customberg (#20945) Contact Form: add filter to allow customizing email headers. (#20912) Blocks: fix HTML markup of buttons added to our blocks. (#20936)
davidlonjon
added a commit
that referenced
this pull request
Sep 7, 2021
* master: Widget Visibility: fix undefined property ref (#20967) Carousel: update prev/next nav button colors (#20940) E2E tests: mention users in Slack based on report name and branch name (#20964) Search: fix search admin page wrapping issue for ultra wide screens (#20962) Instant Search customization: use sentence case consistently (#20931) RP: Use all args for the filter (#20953) renovate: Fix config (#20952) Backport Sync and Heartbeat Changelog from Release (#20950) Update renovate config (#20917) Sync: Defensive coding against E_NOTICE (#20921) Carousel: Fix cursor css selector (#20927) Search: Improve style specificity for result highlights in Customberg (#20945) Contact Form: add filter to allow customizing email headers. (#20912) Blocks: fix HTML markup of buttons added to our blocks. (#20936)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request:
This adds more flexibility and control over user mentions in Slack notifications. We can now configure lists of Slack handles to be mentioned for a branch or for a report name (e.g.
atomicorgutenberg)Jetpack product discussion
1156386383419466-as-1200924739850035
Does this pull request change what data or activity we track or use?
no
Testing instructions:
outputfolder. For this, you can run the tests locally. Then run the script withNODE_ENV=test node ./bin/slack.js suite suiteName. See script's help for more options.