Protect: Improve Network Activated Jetpack check #13267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, Jetpack Protect would complain that the plugin was not network activated even if the plugin *was* network activated but installed in a non-standard directory. Use `plugin_basename()` to always look in the right place.
mdawaffe
added
[Feature] Protect
|
Thank you for the great PR description! When this PR is ready for review, please apply the Scheduled Jetpack release: September 3, 2019. |
|
Related to (and will need rebase against) #13266. |
lezama
approved these changes
Aug 20, 2019
jeherve
added
[Status] Ready to Merge
jeherve
deleted the
fix/protect-multisite-activation-warning-in-nonstandard-directory
branch
matticbot
added
[Status] Needs Changelog
and removed
[Status] Ready to Merge
jeherve
added a commit
that referenced
this pull request
Aug 27, 2019
* 7.7 changelog: initial set of changes * Changelog: add #13154 * Changelog: add #13134 * Changelog: add #12699 and many others * Changelog: add #13127 * Changelog: add #13167 * Changelog: add #13225 * Changelog: add #13179 * Changelog: add #13173 * Changelog: add #13232 * Changelog: add #13137 * Changelog: add #13172 * Changelog: add #13182 * Changelog: add #13200 * Changelog: add #13244 * Changelog: add #13267 * Changelog: add #13204 * changelog: add #13205 * Changelog: add #13183 * Changelog: add #13278 * Changelog: add #13162 * Changelog: add #13268 * Changelog: add #13286 * Changelog: add #13273 * Changelog: add #12474 * Changelog: add #13085 * Changelog: add #13266 * Changelog: add #13306 * Changelog: add #13311 * Changelog: add #13302 * Changelog: add #13196 * Changelog: add #12733 * Changelog: add #13261 * Changelog: add #13322 * Changelog: add #13333 * Changelog: add #13335
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, Jetpack Protect would complain that the plugin was not network activated even if the plugin was network activated but installed in a non-standard directory.
Changes proposed in this Pull Request:
plugin_basename()to always look in the right place.Is this a new feature or does it add/remove features to an existing part of Jetpack?
No: bug fix.
Testing instructions:
Prior to this PR: See the warning about Network Activation.
After this PR: See no warning.
Proposed changelog entry for your changes: