Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change post_type capabilities #13200

Merged
merged 1 commit into from Aug 16, 2019
Merged

Change post_type capabilities #13200

merged 1 commit into from Aug 16, 2019

Conversation

ghost
Copy link

@ghost ghost commented Aug 8, 2019

Fixes #13178

As I recall, the point was to prevent creation of feedback posts. It's intended for feedbacks to only be created through the front-end form.

Changes proposed in this Pull Request:

  • Change the capability create_posts from false to do_not_allow

Proposed changelog entry for your changes:

  • Contact Form: Set the feedback post_type capability create_posts to a valid value.

Testing instructions:

  • Click the menu Feedback. Feedbacks should display as normal with no option to add a feedback.

Fixes #13178

As I recall, the point was to prevent creation of feedback posts. It's intended for feedbacks to only be created through the front-end form.
@ghost ghost self-requested a review August 8, 2019 14:25
@jetpackbot
Copy link

Warnings
⚠️

The PR is missing at least one [Status] label. Suggestions: [Status] In Progress, [Status] Needs Review

⚠️ "Testing instructions" are missing for this PR. Please add some

This is an automated check which relies on PULL_REQUEST_TEMPLATE. We encourage you to follow that template as it helps Jetpack maintainers do their job. If you think 'Testing instructions' or 'Proposed changelog entry' are not needed for your PR - please explain why you think so. Thanks for cooperation 🤖

Generated by 🚫 dangerJS against 45cea2b

@jeherve jeherve added [Feature] Contact Form [Pri] Normal [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. [Type] Bug When a feature is broken and / or not performing as intended labels Aug 8, 2019
@jeherve jeherve added this to the 7.7 milestone Aug 8, 2019
@jeherve jeherve added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. labels Aug 9, 2019
Copy link
Member

@jeherve jeherve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works well in my tests. 👍

@matticbot
Copy link
Contributor

Caution: This PR has changes that must be merged to WordPress.com
Hello tmoorewp! These changes need to be synced to WordPress.com - If you 're an a11n, please commandeer, review, and approve D31373-code before merging this PR. Thank you!

Copy link
Member

@mdawaffe mdawaffe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixes an odd bug: on a multisite, an "Add New" button is available for superadmins wp-admin/ -> Feedback since superadmins can do anything (including false) that is not 'do_not_allow'.

@mdawaffe mdawaffe merged commit 10bd46e into Automattic:master Aug 16, 2019
@matticbot matticbot added [Status] Needs Changelog and removed [Status] Ready to Merge Go ahead, you can push that green button! labels Aug 16, 2019
jeherve added a commit that referenced this pull request Aug 23, 2019
jeherve added a commit that referenced this pull request Aug 27, 2019
* 7.7 changelog: initial set of changes

* Changelog: add #13154

* Changelog: add #13134

* Changelog: add #12699 and many others

* Changelog: add #13127

* Changelog: add #13167

* Changelog: add #13225

* Changelog: add #13179

* Changelog: add #13173

* Changelog: add #13232

* Changelog: add #13137

* Changelog: add #13172

* Changelog: add #13182

* Changelog: add #13200

* Changelog: add #13244

* Changelog: add #13267

* Changelog: add #13204

* changelog: add #13205

* Changelog: add #13183

* Changelog: add #13278

* Changelog: add #13162

* Changelog: add #13268

* Changelog: add #13286

* Changelog: add #13273

* Changelog: add #12474

* Changelog: add #13085

* Changelog: add #13266

* Changelog: add #13306

* Changelog: add #13311

* Changelog: add #13302

* Changelog: add #13196

* Changelog: add #12733

* Changelog: add #13261

* Changelog: add #13322

* Changelog: add #13333

* Changelog: add #13335
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Contact Form [Pri] Normal Touches WP.com Files [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feedback post type has invalid capability
4 participants