Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Social Menu: Update Medium Icon #13204

Merged
merged 1 commit into from
Aug 20, 2019

Conversation

Aurorum
Copy link
Contributor

@Aurorum Aurorum commented Aug 9, 2019

Changes proposed in this Pull Request:

  • The current Medium icon used is outdated, it was changed in 2017. This PR proposes updating it.

Is this a new feature or does it add/remove features to an existing part of Jetpack?

  • N/A

Testing instructions:

  • Create a social menu with Medium as an icon and compare the two.

Before:

Screenshot 2019-08-09 at 12 35 13

After:

Screenshot 2019-08-09 at 12 34 13

Proposed changelog entry for your changes:

  • Social menu: replace the outdated Medium icon with the new official design.

@Aurorum Aurorum requested a review from a team August 9, 2019 11:42
@jetpackbot
Copy link

Warnings
⚠️

The PR is missing at least one [Status] label. Suggestions: [Status] In Progress, [Status] Needs Review

This is an automated check which relies on PULL_REQUEST_TEMPLATE. We encourage you to follow that template as it helps Jetpack maintainers do their job. If you think 'Testing instructions' or 'Proposed changelog entry' are not needed for your PR - please explain why you think so. Thanks for cooperation 🤖

Generated by 🚫 dangerJS against 179b480

Copy link
Member

@jeherve jeherve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works well for me. 👍

Matching PR to update the Medium icon elsewhere in Jetpack:
Automattic/social-logos#71

Noting that Genericons do not include the Medium icon, so to see this result one has to declare support for Social Menu with the SVG option:

add_theme_support( 'jetpack-social-menu', 'svg' );

Full documentation: https://jetpack.com/support/social-menu/

@jeherve jeherve added [Pri] Low [Status] Ready to Merge Go ahead, you can push that green button! [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it labels Aug 19, 2019
@jeherve jeherve added this to the 7.7 milestone Aug 19, 2019
@jeherve
Copy link
Member

jeherve commented Aug 19, 2019

Matching WordPress.com changes: D31683-code

@dereksmart
Copy link
Member

Thank you!

@dereksmart dereksmart merged commit a12fe9a into Automattic:master Aug 20, 2019
@matticbot matticbot added [Status] Needs Changelog and removed [Status] Ready to Merge Go ahead, you can push that green button! labels Aug 20, 2019
jeherve added a commit that referenced this pull request Aug 23, 2019
jeherve added a commit that referenced this pull request Aug 27, 2019
* 7.7 changelog: initial set of changes

* Changelog: add #13154

* Changelog: add #13134

* Changelog: add #12699 and many others

* Changelog: add #13127

* Changelog: add #13167

* Changelog: add #13225

* Changelog: add #13179

* Changelog: add #13173

* Changelog: add #13232

* Changelog: add #13137

* Changelog: add #13172

* Changelog: add #13182

* Changelog: add #13200

* Changelog: add #13244

* Changelog: add #13267

* Changelog: add #13204

* changelog: add #13205

* Changelog: add #13183

* Changelog: add #13278

* Changelog: add #13162

* Changelog: add #13268

* Changelog: add #13286

* Changelog: add #13273

* Changelog: add #12474

* Changelog: add #13085

* Changelog: add #13266

* Changelog: add #13306

* Changelog: add #13311

* Changelog: add #13302

* Changelog: add #13196

* Changelog: add #12733

* Changelog: add #13261

* Changelog: add #13322

* Changelog: add #13333

* Changelog: add #13335
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Extra Sidebar Widgets [Pri] Low Touches WP.com Files [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants