Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

when in debug mode, reduce sitemap cache duration #13179

Merged
merged 4 commits into from
Aug 15, 2019
Merged

when in debug mode, reduce sitemap cache duration #13179

merged 4 commits into from
Aug 15, 2019

Conversation

paulschreiber
Copy link
Contributor

When in debug mode, reduce JP_SITEMAP_INTERVAL and JP_NEWS_SITEMAP_INTERVAL times.

Fixes #11232

Is this a new feature or does it add/remove features to an existing part of Jetpack?

No.

Testing instructions:

  • Go to /sitemap.xml
  • Change an article
  • Wait 61 seconds
  • See that sitemap has update

Proposed changelog entry for your changes:

  • In debug mode, reduce length of sitemap cache times to 60 seconds.

@paulschreiber paulschreiber requested a review from a team August 4, 2019 01:06
@jetpackbot
Copy link

jetpackbot commented Aug 4, 2019 •
edited
Loading

Thank you for the great PR description!

When this PR is ready for review, please apply the [Status] Needs Review label. If you are an a11n, please have someone from your team review the code if possible. The Jetpack team will also review this PR and merge it to be included in the next Jetpack release.

Scheduled Jetpack release: August 6, 2019.
Scheduled code freeze: July 30, 2019

Generated by 🚫 dangerJS against 4bf65c8

@jeherve jeherve added [Pri] Low [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Feature] Sitemaps labels Aug 5, 2019
jeherve
jeherve requested changes Aug 5, 2019
View reviewed changes
modules/sitemaps/sitemap-constants.php Outdated Show resolved Hide resolved
modules/sitemaps/sitemap-constants.php Outdated
@@ -7,6 +7,16 @@
* @author Automattic
*/

/**
* Number of seconds between sitemap and news updates in development code.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it may be worth expanding on that a bit, so folks can quickly understand that this is meant to change default settings that are normally set downer in the file.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've updated the comment. Should you wish to alter it further, please do so (rather than send back to me).

modules/sitemaps/sitemap-constants.php Show resolved Hide resolved
modules/sitemaps/sitemap-constants.php Outdated Show resolved Hide resolved
@jeherve jeherve added the [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! label Aug 5, 2019
@jeherve jeherve added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! labels Aug 5, 2019
@jeherve jeherve added this to the 7.7 milestone Aug 5, 2019
@matticbot
Copy link
Contributor

Caution: This PR has changes that must be merged to WordPress.com
Hello paulschreiber! These changes need to be synced to WordPress.com - If you 're an a11n, please commandeer, review, and approve D31583-code before merging this PR. Thank you!

@dereksmart dereksmart merged commit 77c3100 into Automattic:master Aug 15, 2019
@matticbot matticbot added [Status] Needs Changelog and removed [Status] Ready to Merge Go ahead, you can push that green button! labels Aug 15, 2019
jeherve added a commit that referenced this pull request Aug 23, 2019
@jeherve
Changelog: add #13179
8bf1a57
jeherve added a commit that referenced this pull request Aug 27, 2019
@jeherve
7.7 changelog: initial set of changes (#13190)
190301b 
* 7.7 changelog: initial set of changes

* Changelog: add #13154

* Changelog: add #13134

* Changelog: add #12699 and many others

* Changelog: add #13127

* Changelog: add #13167

* Changelog: add #13225

* Changelog: add #13179

* Changelog: add #13173

* Changelog: add #13232

* Changelog: add #13137

* Changelog: add #13172

* Changelog: add #13182

* Changelog: add #13200

* Changelog: add #13244

* Changelog: add #13267

* Changelog: add #13204

* changelog: add #13205

* Changelog: add #13183

* Changelog: add #13278

* Changelog: add #13162

* Changelog: add #13268

* Changelog: add #13286

* Changelog: add #13273

* Changelog: add #12474

* Changelog: add #13085

* Changelog: add #13266

* Changelog: add #13306

* Changelog: add #13311

* Changelog: add #13302

* Changelog: add #13196

* Changelog: add #12733

* Changelog: add #13261

* Changelog: add #13322

* Changelog: add #13333

* Changelog: add #13335
@kraftbj
Copy link
Contributor

kraftbj commented Apr 30, 2020

r206790-wpcom

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeherve jeherve jeherve approved these changes

Assignees
No one assigned
Labels
[Feature] Sitemaps [Pri] Low Touches WP.com Files [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Projects
None yet
Milestone
7.7
Development

Successfully merging this pull request may close these issues.

Sitemaps: Reduce JP_NEWS_SITEMAP_INTERVAL time in development mode
6 participants
@paulschreiber @jetpackbot @matticbot @kraftbj @jeherve @dereksmart