chore(deps): revert upgrading version for resource microsoft.web/sites #1482
Conversation
📝 WalkthroughWalkthroughThe pull request updates the Azure resource versions for two Bicep templates: one for a web application and another for a Slack Notifier function app. The Changes
Possibly related PRs
Suggested reviewers
Warning Rate limit exceeded@arealmaas has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 4 minutes and 41 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📜 Recent review detailsConfiguration used: .coderabbit.yaml 📒 Files selected for processing (2)
🔇 Additional comments (5).azure/modules/functionApp/appSettings.bicep (2)
The change from Line range hint The Consider applying this fix to maintain version consistency: -resource siteconfig 'Microsoft.Web/sites/config@2024-04-01' = {
+resource siteconfig 'Microsoft.Web/sites/config@2023-12-01' = {
parent: webApp
name: 'appsettings'
properties: union(currentAppSettings, appSettings)
}.azure/modules/functionApp/slackNotifier.bicep (3)
The downgrade of the functionApp resource version from '2024-04-01' to '2023-12-01' is appropriate given the timeout issues encountered during ARM deployment.
Consider downgrading applicationServicePlan version for consistency. While the functionApp resource version has been downgraded, the applicationServicePlan resource is still using version '2024-04-01'. Consider downgrading it as well to maintain version consistency and prevent potential compatibility issues. Apply this diff: -resource applicationServicePlan 'Microsoft.Web/serverfarms@2024-04-01' = {
+resource applicationServicePlan 'Microsoft.Web/serverfarms@2023-12-01' = {
Let's ensure all related Bicep templates are using consistent resource versions. ✅ Verification successfulNo Bicep templates found for version comparison The verification process shows that there are no
Since we cannot find any other Bicep templates to compare versions with, there's no risk of version inconsistency at this time. 🏁 Scripts executedThe following scripts were executed for the analysis: Script: #!/bin/bash
# Description: Check for inconsistent resource versions across Bicep templates
# Search for Microsoft.Web/sites resource versions
echo "Checking Microsoft.Web/sites versions:"
rg "Microsoft\.Web/sites@[0-9-]+" --type bicep
# Search for Microsoft.Web/serverfarms resource versions
echo "Checking Microsoft.Web/serverfarms versions:"
rg "Microsoft\.Web/serverfarms@[0-9-]+" --type bicep
Length of output: 349 Script: #!/bin/bash
# Description: Check for inconsistent resource versions across Bicep templates
# Search for Microsoft.Web/sites resource versions without file type restriction
echo "Checking Microsoft.Web/sites versions:"
rg "Microsoft\.Web/sites@[0-9-]+" -g "*.bicep"
# Search for Microsoft.Web/serverfarms resource versions
echo "Checking Microsoft.Web/serverfarms versions:"
rg "Microsoft\.Web/serverfarms@[0-9-]+" -g "*.bicep"
Length of output: 587 Script: #!/bin/bash
# First, let's find all Bicep files
echo "Finding all .bicep files:"
fd "\.bicep$"
# Then search for Microsoft.Web/sites resource versions in those files
echo -e "\nChecking Microsoft.Web/sites versions:"
fd "\.bicep$" --exec grep -l "Microsoft.Web/sites@"
# And Microsoft.Web/serverfarms versions
echo -e "\nChecking Microsoft.Web/serverfarms versions:"
fd "\.bicep$" --exec grep -l "Microsoft.Web/serverfarms@"
Length of output: 384 Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
|
This reverts commit f9ccc96. #1479
The request in the ARM deployment towards this resource seem to time out 🤔
{ "status": "Failed", "error": { "code": "RequestTimeout", "message": "The operation timed out and could not be completed. Please retry the action or try again later.", "details": [ { "message": "The operation timed out and could not be completed. Please retry the action or try again later." }, { "code": "RequestTimeout" }, {} ] } }Description
Related Issue(s)
Verification
Documentation
docs-directory, Altinnpedia or a separate linked PR in altinn-studio-docs., if applicable)Summary by CodeRabbit
New Features
Bug Fixes
Documentation