chore: revert function app version updates #1483
Conversation
📝 WalkthroughWalkthroughThe pull request updates the version of several Azure resources in Bicep files for Function Apps. Specifically, it changes the Changes
Possibly related PRs
Suggested reviewers
📜 Recent review detailsConfiguration used: .coderabbit.yaml 📒 Files selected for processing (2)
🔇 Additional comments (5).azure/modules/functionApp/appSettings.bicep (2)Line range hint Since this is a version reversion, we should ensure all related Function App resources use the same API version. Let's check for version consistency: #!/bin/bash
# Description: Verify version consistency across related Function App resources
# Look for other Function App related resources that might need version alignment
echo "Checking for Function App related resources..."
rg 'Microsoft\.Web/(serverfarms|sites|functions)@202[34]' --type bicep -A 3Line range hint The version downgrade to Let's verify the version compatibility and support status: ✅ Verification successfulVersion consistency confirmed across Function App resources The version downgrade to
Note: There is one instance of 🏁 Scripts executedThe following scripts were executed for the analysis: Script: #!/bin/bash
# Description: Check for version usage across Bicep files and validate Azure provider versions
# Check version consistency across all Bicep files
echo "Checking version usage across all Bicep files..."
rg -l 'Microsoft\.Web/sites(@|/config@)2023-12-01' --type bicep
# Check for any other Web/sites versions that might need alignment
echo "Checking for other Web/sites versions..."
rg -l 'Microsoft\.Web/sites(@|/config@)202[34]' --type bicep
Length of output: 520 Script: #!/bin/bash
# Let's try a different approach without relying on file type detection
# Search for Web/sites version patterns in all files with .bicep extension
echo "Checking version patterns in Bicep files..."
find . -name "*.bicep" -type f -exec grep -l "Microsoft.Web/sites" {} \;
echo -e "\nChecking specific version patterns..."
for f in $(find . -name "*.bicep" -type f); do
echo "=== $f ==="
grep -A 2 "Microsoft.Web/sites" "$f" 2>/dev/null || true
done
Length of output: 9031 .azure/modules/functionApp/slackNotifier.bicep (3)Line range hint The alert rule is using a preview version ( #!/bin/bash
# Description: Check alert rule API versions across the codebase
# Search for other alert rule definitions
rg "Microsoft.Insights/scheduledQueryRules@" -g "*.bicep"
# Look for any existing GA versions in use
ast-grep --pattern 'resource $_ '\''Microsoft.Insights/scheduledQueryRules@$_'\'' = {
$$$
}'
The version change from '2024-04-01' to '2023-12-01' aligns with the PR objective. This is a stable version that should resolve the function app update issues. ✅ Verification successfulVersion change is isolated and consistent The version change to '2023-12-01' for Microsoft.Web/serverfarms is the only instance in the codebase, making this a clean and isolated change. This confirms there are no version inconsistencies to address across other Bicep templates. 🏁 Scripts executedThe following scripts were executed for the analysis: Script: #!/bin/bash
# Description: Verify the Azure provider version compatibility
# Check if this version is used consistently across other Bicep files
# Search for any other App Service Plan resource definitions
ast-grep --pattern 'resource $_ '\''Microsoft.Web/serverfarms@$_'\'' = {
$$$
}'
# Search for version references in other files
rg "Microsoft.Web/serverfarms@" -g "*.bicep"
Length of output: 277 Script: #!/bin/bash
# Let's try a different approach to find Bicep files and their content
# First, find all Bicep files
fd -e bicep
# Then search for App Service Plan definitions with version
rg "Microsoft.Web/serverfarms@" --type bicep
# Also check for any references to serverfarms in general
rg "Microsoft.Web/serverfarms" --type bicep
Length of output: 162 Script: #!/bin/bash
# Let's try without file type specification since Bicep isn't recognized
# Find Bicep files first
fd -e bicep
# Then use these to search for App Service Plan definitions
rg "Microsoft.Web/serverfarms" .azure/
Length of output: 174 Line range hint While the configuration is functional, consider the following security improvements:
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
arealmaas
changed the title
|
Description
For some reason the function app cannot be updated in Bicep. Reverting rest of the changes done to the upgrading of versions for the function app
Related Issue(s)
Verification
Documentation
docs-directory, Altinnpedia or a separate linked PR in altinn-studio-docs., if applicable)Summary by CodeRabbit
New Features
Bug Fixes