chore(azure): Replace traces.message with customDimensions.MessageTemplate in slackNotifier #1437
Conversation
📝 WalkthroughWalkthroughThe pull request introduces modifications to the Bicep template for the Slack Notifier function app. Key changes include updates to the Changes
Possibly related PRs
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
.azure/modules/functionApp/slackNotifier.bicep (1)
181-181: LGTM! Consider improving readability with column aliasing.The change to use
customDimensions_MessageTemplatein the coalesce is correct and consistent with the previous change.Consider using explicit column aliasing in the summarize statement for better readability:
- tostring(customDimensions.MessageTemplate), + tostring(customDimensions.MessageTemplate) as MessageTemplate,Then update the coalesce to use the alias:
- | extend Details = coalesce(customDimensions_MessageTemplate, problemId) + | extend Details = coalesce(MessageTemplate, problemId)
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
📒 Files selected for processing (1)
.azure/modules/functionApp/slackNotifier.bicep(2 hunks)
🔇 Additional comments (1)
.azure/modules/functionApp/slackNotifier.bicep (1)
171-171: LGTM! Verify query results in Azure Portal.
The change to use customDimensions.MessageTemplate is correct and aligns with the PR objective. The tostring() casting is properly applied.
To ensure the query continues to work as expected, please verify the results in Azure Portal:
- Navigate to Application Insights
- Use Analytics to test this query segment:
This will help confirm that MessageTemplate contains the expected values.
✅ Verification successful
The change to use customDimensions.MessageTemplate is correctly implemented
After examining the full bicep template, I can verify that the change is correctly implemented within the KQL query. The tostring(customDimensions.MessageTemplate) is:
- Used appropriately in the summarize statement
- Properly type-cast using
tostring() - Referenced correctly in the
coalescefunction viacustomDimensions_MessageTemplate - Part of a well-structured query that handles both exceptions and traces
The query structure ensures that the MessageTemplate will be used for message grouping in the alert rule, which aligns with the PR objective.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
traces
| where severityLevel >= 2
| project message,
customDimensions.MessageTemplate,
severityLevel
| take 10
Length of output: 246
Script:
#!/bin/bash
# Let's examine the bicep file to understand the full context of the query
cat .azure/modules/functionApp/slackNotifier.bicep
Length of output: 7140
knuhau
deleted the
chore/slack-alerts-customdimensions-messagetemplate
branch
Replace traces.message with customDimensions.MessageTemplate in the slackNotifier for improved grouping
Summary by CodeRabbit
Bug Fixes
Chores