chore(slacknotifier): remove fusion-cache timeout exception from slack alerts

[arealmaas]

Description

We cannot separate between soft-timeouts and hard-timeouts in fusioncache. If we get a hard-timeout we should get an indication of this through our own exception handling

Related Issue(s)

Related issue: ZiggyCreatures/FusionCache#267

Verification

• Your code builds clean without any errors or warnings
• Manual testing done (required)
• Relevant automated test added (if you find this hard, leave it and we'll help out)

Documentation

• Documentation is updated (either in docs-directory, Altinnpedia or a separate linked PR in altinn-studio-docs., if applicable)

Summary by CodeRabbit

• New Features

  • Enhanced alerting criteria for exceptions in the Slack Notifier function app.
  • Added a new action group to notify the development team via Slack.

• Improvements

  • Defined specific allowed values for SKU parameters to ensure valid resource deployment.
  • Configured the function app with a SystemAssigned identity and integrated Key Vault for secure webhook URL storage.

[coderabbitai]

📝 Walkthrough

Walkthrough

The changes in this pull request involve updates to the Bicep template for the Slack Notifier function app. Key modifications include the introduction of a new condition in the Kusto query for the exceptionOccuredAlertRule resource to exclude specific exception types. The sku parameter has been defined with allowed values, and the functionApp resource is now configured with a SystemAssigned identity. Additionally, an action group resource is created to notify the development team via the function app's HTTP trigger URL.

Changes

File Path	Change Summary
.azure/modules/functionApp/slackNotifier.bicep	- Added param sku Sku to define allowed SKU values. - Updated Kusto query condition in exceptionOccuredAlertRule to exclude ZiggyCreatures.Caching.Fusion.SyntheticTimeoutException. - Configured functionApp with SystemAssigned identity. - Structured appSettings to include Key Vault reference for Slack webhook URL. - Defined notifyDevTeam resource for action group notifications.

Possibly related PRs

• chore: generalized query for slack notifier #1125: Modifies filtering logic within a query in the same Bicep file, refining exception monitoring criteria.
• chore(azure): Exclude APIM errors from Slack alerts channel #1156: Alters filtering criteria for exceptions in the same Bicep file, specifically excluding exceptions related to API Management.
• chore(slacknotifier): remove health checks from slack alerts #1269: Introduces a new sku parameter and modifies the exceptionOccuredAlertRule, directly relating to the changes in the main PR.

Suggested reviewers

• seanes
• oskogstad

---

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between 1e9c350 and 5ef0ee6.

📒 Files selected for processing (1)

• .azure/modules/functionApp/slackNotifier.bicep (1 hunks)

🧰 Additional context used

🔇 Additional comments (1)

.azure/modules/functionApp/slackNotifier.bicep (1)

161-162: Appropriately excludes Fusion SyntheticTimeoutException from alerts

The added filter correctly excludes ZiggyCreatures.Caching.Fusion.SyntheticTimeoutException from the exception alerts, aligning with the PR objective to remove unwanted Slack notifications for these timeout exceptions.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud