Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[help wanted] add unit-test for modifyContainerNamespaceOptions #1911

Closed
starnop opened this issue Jul 26, 2018 · 0 comments · Fixed by #1945
Closed

[help wanted] add unit-test for modifyContainerNamespaceOptions #1911

starnop opened this issue Jul 26, 2018 · 0 comments · Fixed by #1945
Labels
areas/test

Comments

@starnop
Copy link
Contributor

starnop commented Jul 26, 2018

Ⅰ. Issue Description

Add unit-test for modifyContainerNamespaceOptions method which locate on cri/v1alpha1/cri_utils.go.

You can take env_test.go for reference.

Ⅱ. Describe what happened

Ⅲ. Describe what you expected to happen

Ⅳ. How to reproduce it (as minimally and precisely as possible)

Ⅴ. Anything else we need to know?

Ⅵ. Environment:

  • pouch version (use pouch version):
  • OS (e.g. from /etc/os-release):
  • Kernel (e.g. uname -a):
  • Install tools:
  • Others:
@scuzhangp123 scuzhangp123 mentioned this issue Jul 30, 2018
Closed
@MarkLux MarkLux mentioned this issue Jul 31, 2018
Merged
zhusinan0601 added a commit to zhusinan0601/pouch that referenced this issue Jul 31, 2018
@zhusinan0601
group4:add unit test to modifiedContainerNamespaceOptions , fix Aliyu…
383de6c 
…nContainerService#1911

Signed-off-by: zhusinan0601 <[email protected]>
@hanshasheying hanshasheying mentioned this issue Jul 31, 2018
Closed
@scuzhangp123 scuzhangp123 mentioned this issue Jul 31, 2018
Closed
@kiss-keray kiss-keray mentioned this issue Jul 31, 2018
Closed
zhusinan0601 added a commit to zhusinan0601/pouch that referenced this issue Jul 31, 2018
@zhusinan0601
group4:add unit test to modifiedContainerNamespaceOptions , fix Aliyu…
3c1f151 
…nContainerService#1911

Signed-off-by: zhusinan0601 <[email protected]>
@KevinLeung611 KevinLeung611 mentioned this issue Jul 31, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
areas/test
Projects
None yet
Milestone
No milestone
2 participants
@starnop @pouchrobot