Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue1911 #2024

Closed
wants to merge 11 commits into from
Closed

Issue1911 #2024

wants to merge 11 commits into from

Conversation

KevinLeung611
Copy link

Ⅰ. Describe what this PR did

Ⅱ. Does this pull request fix one issue?

fix issue #1911

Ⅲ. Describe how you did it

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

shanbo.lkw added 5 commits July 31, 2018 10:35
@pouchrobot
Copy link
Collaborator

Thanks for your contribution. 🍻 @KevinLeung-nice
While we thought PR TITLE could be more specific, longer than 20 chars.
Please edit this PR title instead of opening a new one.
More details, please refer to https://github.com/alibaba/pouch/blob/master/CONTRIBUTING.md

@pouchrobot
Copy link
Collaborator

We found this is your first time to contribute to Pouch, @KevinLeung-nice
👏 We really appreciate it.
Just remind that you have read the contribution guide: https://github.com/alibaba/pouch/blob/master/CONTRIBUTING.md
If you didn't, you should do that first. If done, welcome again and please enjoy hacking! 🍻

@CLAassistant
Copy link

CLAassistant commented Jul 31, 2018

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


shanbo.lkw seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

shanbo.lkw added 4 commits July 31, 2018 12:19
Signed-off-by: shanbo.lkw <[email protected]>
Signed-off-by: shanbo.lkw <[email protected]>
Signed-off-by: shanbo.lkw <[email protected]>
Signed-off-by: shanbo.lkw <[email protected]>
@pouchrobot pouchrobot added size/L and removed size/XL labels Jul 31, 2018
shanbo.lkw added 2 commits July 31, 2018 13:31
Signed-off-by: shanbo.lkw <[email protected]>
Signed-off-by: shanbo.lkw <[email protected]>
@pouchrobot
Copy link
Collaborator

@KevinLeung-nice Thanks for your contribution. 🍻
Please sign off in each of your commits.

@YaoZengzeng
Copy link
Contributor

Would you please squash your commits to make them more clear?

Thank you :)

@pouchrobot
Copy link
Collaborator

ping @KevinLeung-nice
Conflict happens after merging a previous commit.
Please rebase the branch against master and push it back again. Thanks a lot.

@YaoZengzeng
Copy link
Contributor

We have merged a PR which solve the same problem

Thanks for your work

Close this now :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants