-
Notifications
You must be signed in to change notification settings - Fork 949
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: add a unit-test for apis/opts/ports.go & add a unit-test for method getSELinuxSecurityOpts in cri_utils.go & add a unit-test for method modifyContainerNamespaceOptions in cri_utils.go #1935
Conversation
Signed-off-by: YaoZengzeng <[email protected]>
…ing{"127.0.0.1:2:2/tcp"}, expose: []string{"20-21/tcp"}}, want: map[string]interface{}{"2/tcp": struct{}{}, "20/tcp": struct{}{}, "21/tcp":struct{}{}}, wantErr: false},o
We found this is your first time to contribute to Pouch, @scuzhangp123 |
Codecov Report
@@ Coverage Diff @@
## master #1935 +/- ##
==========================================
+ Coverage 63.3% 63.44% +0.14%
==========================================
Files 200 200
Lines 15521 15521
==========================================
+ Hits 9825 9847 +22
+ Misses 4456 4427 -29
- Partials 1240 1247 +7
|
@scuzhangp123 Thanks for your contribution. 🍻 |
Could you please squash your commits and make them more clear? :) |
ping @scuzhangp123 |
Ⅰ. Describe what this PR did
add a unit-test for ports.go
add a unit-test for method getSELinuxSecurityOpts in cri_utils.go
add a unit-test for method modifyContainerNamespaceOptions in cri_utils.go
Ⅱ. Does this pull request fix one issue?
fix issues #1906
fix issues #1912
fix issues #1911
Ⅲ. Describe how you did it
Build unit test by condition combination coverage(ccc).
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews
Come from Group 5