Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[help wanted] add unit-test for apis/opts/ports.go #1906

Closed
2 tasks
chuanchang opened this issue Jul 26, 2018 · 0 comments · Fixed by #1976
Closed
2 tasks

[help wanted] add unit-test for apis/opts/ports.go #1906

chuanchang opened this issue Jul 26, 2018 · 0 comments · Fixed by #1976
Labels
areas/test

Comments

@chuanchang
Copy link
Contributor

chuanchang commented Jul 26, 2018 •
edited
Loading

Ⅰ. Issue Description

Need to be covered APIs testing as follows:

  • ParseExposedPorts
  • ValidateExposedPorts

NOTE: for ValidateExposedPorts item, at present, it hasn't be implemented, it will be better if you can complete it, of course, you also need to add unit test for it.

Ⅱ. Describe what happened

Ⅲ. Describe what you expected to happen

Ⅳ. How to reproduce it (as minimally and precisely as possible)

Ⅴ. Anything else we need to know?

Ⅵ. Environment:

  • pouch version (use pouch version):
  • OS (e.g. from /etc/os-release):
  • Kernel (e.g. uname -a):
  • Install tools:
  • Others:
This was referenced Jul 30, 2018
Closed
Closed
@Lapis-Hong Lapis-Hong mentioned this issue Jul 31, 2018
Closed
@devily devily mentioned this issue Jul 31, 2018
Merged
@MoriatyC MoriatyC mentioned this issue Jul 31, 2018
Closed
@Lapis-Hong Lapis-Hong mentioned this issue Jul 31, 2018
Closed
@liuxuan1-1 liuxuan1-1 mentioned this issue Jul 31, 2018
Closed
@scuzhangp123 scuzhangp123 mentioned this issue Jul 31, 2018
Closed
@qocean qocean mentioned this issue Jul 31, 2018
Closed
@liuxuan1-1 liuxuan1-1 mentioned this issue Jul 31, 2018
Closed
@BuggMaker BuggMaker mentioned this issue Jul 31, 2018
Closed
@xcg-code xcg-code mentioned this issue Jul 31, 2018
Closed
fuweid pushed a commit that referenced this issue Aug 1, 2018
Merge pull request #1976 from devily/master
703b26a 
test: add unit-test for apis/opts/ports.go

fixes #1906
devily added a commit to devily/pouch that referenced this issue Aug 2, 2018
@devily
Revert "BJ266-4: Add unit-test for apis/opts/ports.go, fix AliyunCont…
b1c87fc 
…ainerService#1906 "
@pouchrobot pouchrobot mentioned this issue Aug 2, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
areas/test
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

BJ266-4: Add unit-test for apis/opts/ports.go, fix #1906 devily/pouch
2 participants
@chuanchang @pouchrobot