Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add unit-test for apis/opts/ports.go #1992

Closed
wants to merge 1 commit into from
Closed

add unit-test for apis/opts/ports.go #1992

wants to merge 1 commit into from

Conversation

liuxuan1-1
Copy link

Ⅰ. Describe what this PR did

add a unit-test for ports.go

Ⅱ. Does this pull request fix one issue?

fix issues #1906

Ⅲ. Describe how you did it

Build unit test by condition combination coverage(ccc).

Ⅳ. Describe how to verify it

By code review and walk-through

Ⅴ. Special notes for reviews

@pouchrobot
Copy link
Collaborator

@TheKiteRunners Thanks for your contribution. 🍻
Please sign off in each of your commits.

@CLAassistant
Copy link

CLAassistant commented Jul 31, 2018

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


zhixuan.liuzhixuan seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@pouchrobot
Copy link
Collaborator

We found this is your first time to contribute to Pouch, @TheKiteRunners
👏 We really appreciate it.
Just remind that you have read the contribution guide: https://github.com/alibaba/pouch/blob/master/CONTRIBUTING.md
If you didn't, you should do that first. If done, welcome again and please enjoy hacking! 🍻

@liuxuan1-1 liuxuan1-1 closed this Jul 31, 2018
@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request head (lzx@4b04d4c). Click here to learn what that means.
The diff coverage is n/a.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants