Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issue #1906 #1983

Closed
wants to merge 3 commits into from
Closed

fix issue #1906 #1983

wants to merge 3 commits into from

Conversation

Lapis-Hong
Copy link

Ⅰ. Describe what this PR did
add use cases

Ⅱ. Does this pull request fix one issue?
#1906

Ⅲ. Describe how you did it
1.read sourcecode
2.find out all possible situations
3.discover good and bad cases
4.test

Ⅳ. Describe how to verify it
go test ./apis/opts/ports.go ./apis/opts/ports_test.go

Ⅴ. Special notes for reviews
bad case, unexpected output
bad case, first if
bad case, second if
bad case, third if
found last if in source code is not needed, it never happens.

@pouchrobot
Copy link
Collaborator

Thanks for your contribution. 🍻 @Lapis-Hong
While we thought PR TITLE could be more specific, longer than 20 chars.
Please edit this PR title instead of opening a new one.
More details, please refer to https://github.com/alibaba/pouch/blob/master/CONTRIBUTING.md

@CLAassistant
Copy link

CLAassistant commented Jul 31, 2018

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@pouchrobot
Copy link
Collaborator

We found this is your first time to contribute to Pouch, @Lapis-Hong
👏 We really appreciate it.
Just remind that you have read the contribution guide: https://github.com/alibaba/pouch/blob/master/CONTRIBUTING.md
If you didn't, you should do that first. If done, welcome again and please enjoy hacking! 🍻

Signed-off-by: Lapis-Hong <[email protected]>
@pouchrobot
Copy link
Collaborator

@Lapis-Hong Thanks for your contribution. 🍻
Please sign off in each of your commits.

@Lapis-Hong Lapis-Hong closed this Jul 31, 2018
@codecov-io
Copy link

Codecov Report

Merging #1983 into master will decrease coverage by 12.67%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #1983       +/-   ##
===========================================
- Coverage   63.31%   50.64%   -12.68%     
===========================================
  Files         200      200               
  Lines       15522    15522               
===========================================
- Hits         9828     7861     -1967     
- Misses       4455     6503     +2048     
+ Partials     1239     1158       -81
Flag Coverage Δ
#criv1alpha1test 33.79% <ø> (-0.06%) ⬇️
#criv1alpha2test ?
#integrationtest 38.4% <ø> (-0.03%) ⬇️
#unittest 72% <ø> (+51.13%) ⬆️
Impacted Files Coverage Δ
cri/stream/errors.go 0% <0%> (-100%) ⬇️
cri/v1alpha2/cri_types.go 0% <0%> (-100%) ⬇️
pkg/multierror/def.go 15.38% <0%> (-84.62%) ⬇️
daemon/logger/loggerutils/tag.go 0% <0%> (-81.82%) ⬇️
cri/v1alpha2/cri_utils.go 0% <0%> (-80.16%) ⬇️
cri/v1alpha2/cri_stream.go 0% <0%> (-80%) ⬇️
cri/v1alpha2/server.go 0% <0%> (-79.85%) ⬇️
cri/v1alpha2/service/cri.go 0% <0%> (-73.34%) ⬇️
apis/opts/config/blkio.go 0% <0%> (-69.67%) ⬇️
cri/v1alpha2/cri.go 0% <0%> (-66.5%) ⬇️
... and 42 more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants