Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add unit test for modifyContainerNamespaceOptions #2012

Closed

Conversation

kiss-keray
Copy link

Ⅰ. Describe what this PR did

dd unit test for modifyContainerNamespaceOptions

Ⅱ. Does this pull request fix one issue?

#Fix: #1911

Ⅲ. Describe how you did it

input test data

Ⅳ. Describe how to verify it

test pass

Ⅴ. Special notes for reviews

NONE

@pouchrobot
Copy link
Collaborator

@kiss-yu Thanks for your contribution. 🍻
Please sign off in each of your commits.

@pouchrobot
Copy link
Collaborator

We found this is your first time to contribute to Pouch, @kiss-yu
👏 We really appreciate it.
Just remind that you have read the contribution guide: https://github.com/alibaba/pouch/blob/master/CONTRIBUTING.md
If you didn't, you should do that first. If done, welcome again and please enjoy hacking! 🍻

@YaoZengzeng
Copy link
Contributor

We have merged a PR which solve the same problem

Thanks for your work

Close this now :)

@pouchrobot
Copy link
Collaborator

ping @kiss-yu
Conflict happens after merging a previous commit.
Please rebase the branch against master and push it back again. Thanks a lot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[help wanted] add unit-test for modifyContainerNamespaceOptions
3 participants