-
Notifications
You must be signed in to change notification settings - Fork 212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(release): publish agoric-upgrade-13 #8633
Conversation
agoric-upgrade-13
it's only for installing the bin and importing that bin module
refactor clientSupport to not depend on agoric-cli package
* fix(inter-protocol): brands in CLI need not start with A-Z * test(inter-protocol): clientSupport for initial non-uppercase * fixup! fix(inter-protocol): brands in CLI need not start with A-Z --------- Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
The backport referenced above has the agd process hang around after halting. Wrote a wrapper utility which scans stderr for the halt application message, interrupts the process, then propagates its error signal. Conventional shell scripting is not up to the challenge of expressing this behavior.
…#305" This reverts commit efcc3b0. We decided to roll back the problematic change (agoric-labs/cosmos-sdk#305).
feat: update ibc-go to v4, adapt packages and API
…t-found fix(cli): handle not found error in vstorage requests
needs instance based on --pair
fix(casting): dont crash on bad capdata
fix(agops): fix continuing id lookup in oracle setPrice
Exporting a state-sync snapshot is a read-only operation, and is designed to run "in the background", i.e. in parallel with normal mutating operations. It accomplishes this by opening a read-only transaction right away, effectively capturing a snapshot of the SQLite database state, to insulate the export process from ongoing writes by the execution host. The cosmic-swingset exporter starts with a query of `host.height`, to confirm that the database has not already advanced to a new block before this snapshot/read-transaction can be taken. Previously, this query worked by using `openSwingStore`, and then calling `hostStorage.hostKVStore.get('host.height')`. This had two problems: * TOCTTOU: the `hostKVStore.get` used a different DB connection (and different txn) than the exporter, so it might return a different height, negating the accuracy of the consistency check * read-write txn: `openSwingStore` creates a read-*write* txn, even when merely opening the DB (because it might need to create the initial tables). This txn is closed right away, before `openSwingStore()` returns, so it did not present a threat to ongoing operations. But if the exporter was created while the ongoing execution side already had its own read-write txn open (e.g. while `controller.run()` was running), then it would fail, and `makeSwingStoreExporter` would fail with `SQLITE_BUSY` Instead, we take advantage of the new `swingStoreExporter.getHostKV()` API, and use *it* to fetch `host.height`. Unlike the normal swingstore, the swingstore-exporter refrains from creating read-write transactions entirely. So the cosmic-swingset export code can safely query the height without fear of getting the wrong value or failing because of an ongoing write transaction. We think this should fix the SQLITE_BUSY errors. refs #8523
…lock fix: export state-sync snapshot without a DB write-lock
feat: allow clawback vesting accounts to return grants
Auto-provision smart wallet
* feat(cosmos): un-wire x/crisis * fixup! feat(cosmos): un-wire x/crisis --------- Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
The release commit is be59032, rest comes from previous |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall.
Left couple of comments and wanted you to double if we need to update the following file?
packages/xsnap/package.json
@@ -24,7 +14,7 @@ By default pre-releases use the lastest image tagged `dev` in our [container rep | |||
a specific build: | |||
|
|||
```shell | |||
DEST_IMAGE=docker pull ghcr.io/agoric/agoric-sdk:20230515033839-e56ae7 | |||
DEST_IMAGE=ghcr.io/agoric/agoric-sdk:20230515033839-e56ae7 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to change this tag?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's just an example in the readme
// upgrade12Handler performs standard upgrade actions plus custom actions for upgrade-12. | ||
func upgrade12Handler(app *GaiaApp, targetUpgrade string) func(sdk.Context, upgradetypes.Plan, module.VersionMap) (module.VersionMap, error) { | ||
// upgrade13Handler performs standard upgrade actions plus custom actions for upgrade-13. | ||
func upgrade13Handler(app *GaiaApp, targetUpgrade string) func(sdk.Context, upgradetypes.Plan, module.VersionMap) (module.VersionMap, error) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If there is nothing specific in this function, should we rename it to just upgradeHandler?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's how we've been managing upgrade handlers. This change is coming from #8588 which prepared the upgrade-13 branch
@@ -43,4 +43,4 @@ run_test: | |||
shell: | |||
docker exec -it `docker ps --latest --format json | jq -r .Names` bash | |||
|
|||
.PHONY: local_sdk agoric-upgrade-7-2 agoric-upgrade-8 agoric-upgrade-8-1 agoric-upgrade-9 agoric-upgrade-10 agoric-upgrade-11 agoric-upgrade-12 build build_test run | |||
.PHONY: local_sdk agoric-upgrade-13 build build_test run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why we not need to run all the upgrades like before?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because those are now part of agoric-3-proposals. This was some cleanup done in #8588
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mhofman I am conditionally approving this PR. Please check if you need to update version numbers in the following file before merging this PR.
Oh I see what you mean. The xsnap-lockdown version didn't get bumped, and arguably it should to represent the fact the bundle on chain is now different. I'll see what I can do. |
Reflect patch-package of transitive dependency
- @agoric/[email protected] - @agoric/[email protected] - @agoric/[email protected] - [email protected] - @agoric/[email protected] - @agoric/[email protected] - @agoric/[email protected] - @agoric/[email protected] - @agoric/[email protected] - @agoric/[email protected] - @agoric/[email protected] - @agoric/[email protected] - @agoric/[email protected] - @agoric/[email protected] - @agoric/[email protected] - @agoric/[email protected] - @agoric/[email protected] - @agoric/[email protected] - @agoric/[email protected] - @agoric/[email protected] - @agoric/[email protected] - @agoric/[email protected] - @agoric/[email protected] - @agoric/[email protected] - @agoric/[email protected] - @agoric/[email protected] - @agoric/[email protected] - @agoric/[email protected] - @agoric/[email protected] - @agoric/[email protected] - @agoric/[email protected] - @agoric/[email protected] - @agoric/[email protected] - @agoric/[email protected] - @agoric/[email protected] - @agoric/[email protected] - @agoric/[email protected] - @agoric/[email protected]
be59032
to
5a6cdeb
Compare
@toliaqat I forced a version bump on Overall diff since reviewed: be59032..5a6cdeb PTAL |
@mhofman thank you. I think because of the broken tool, we missed u11wf.0 tag updates in the past as well. And update version in eslint-config |
To be clear, it's totally normal for packages that didn't experience any changes to not get their version bumped. In the case of The other packages can stay without a version change. |
🚀 |
Packages that have NEWS.md updates