Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(inter-protocol): brands in CLI need not start with A-Z #8258

Merged
merged 4 commits into from
Oct 5, 2023
Merged

fix(inter-protocol): brands in CLI need not start with A-Z #8258

merged 4 commits into from
Oct 5, 2023

Conversation

dckc
Copy link
Member

@dckc dckc commented Aug 25, 2023 •
edited
Loading

closes: #8281
refs: #XXXX

Description

Security Considerations

Scaling Considerations

Documentation Considerations

Testing Considerations

  • IOU a unit test

manually tested:

$ yarn run --silent agops inter bid by-price --give 10IST --price 10 --from gov1 --maxBuy 100000stATOM
2023-08-25T22:12:45.489227787Z tx not in block 240202 retrying...
2023-08-25T22:12:45.489227787Z tx not in block 240202 retrying...
bid is broadcast:
{"timestamp":"2023-08-25T22:12:50Z","height":"240203","offerId":"bid-1693001571527","txhash":"F4742187069F7FE868E03C476FE0807A2325F8130264BCE53ACF00680677F3C2"}
{"id":"bid-1693001571527","price":"10 IST/stATOM","give":{"Bid":"10 IST"},"maxBuy":"100000 stATOM","result":"Your bid has been accepted"}

Upgrade Considerations

cc @otoole-brendan

@dckc dckc force-pushed the dc-inter-cli-brand-case branch from 9e8799d to d8b848a Compare October 3, 2023 01:17
@dckc dckc requested review from turadg and iomekam October 3, 2023 01:18
@dckc dckc marked this pull request as ready for review October 3, 2023 01:18
@dckc dckc force-pushed the dc-inter-cli-brand-case branch from 31b1bad to 1996f10 Compare October 4, 2023 18:02
turadg
turadg approved these changes Oct 4, 2023
View reviewed changes
Copy link
Member

@turadg turadg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 test

@dckc dckc added automerge:squash Automatically squash merge bypass:linear-history Allow merge and fixup commits in PR labels Oct 4, 2023
@dckc
Copy link
Member Author

dckc commented Oct 5, 2023

@Mergifyio requeue

@mergify
Copy link
Contributor

mergify bot commented Oct 5, 2023

requeue

✅ The queue state of this pull request has been cleaned. It can be re-embarked automatically

@mergify mergify bot merged commit 2ac22d3 into master Oct 5, 2023
71 checks passed
@mergify mergify bot deleted the dc-inter-cli-brand-case branch October 5, 2023 18:26
mhofman pushed a commit that referenced this pull request Dec 6, 2023
@dckc @mergify @mhofman
fix(inter-protocol): brands in CLI need not start with A-Z (#8258)
fd9a44d 
* fix(inter-protocol): brands in CLI need not start with A-Z

* test(inter-protocol): clientSupport for initial non-uppercase

* fixup! fix(inter-protocol): brands in CLI need not start with A-Z

---------

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
@mhofman mhofman mentioned this pull request Dec 6, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@turadg turadg turadg approved these changes

@iomekam iomekam Awaiting requested review from iomekam

Assignees
No one assigned
Labels
automerge:squash Automatically squash merge bypass:linear-history Allow merge and fixup commits in PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unable to use setPrice in CLI to reliably change ATOM and stATOM price (for testing)
2 participants
@dckc @turadg