feat: update ibc-go to v4, adapt packages and API #8409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelfig
approved these changes
Nov 5, 2023
golang/cosmos/cmd/runtillmsg/main.go
Outdated
|
Can we merge agoric-labs/cometbft#5 first and only update the cometbft dependency once. |
mhofman
reviewed
Nov 6, 2023
golang/cosmos/go.mod
Outdated
| @@ -142,14 +155,11 @@ replace google.golang.org/grpc => google.golang.org/grpc v1.33.2 | |||
|
|
|||
| // At least until post-v0.34.14 is released with | |||
| // https://github.com/tendermint/tendermint/issue/6899 resolved. | |||
| replace github.com/tendermint/tendermint => github.com/agoric-labs/tendermint v0.34.23-alpha.agoric.3 | |||
| replace github.com/tendermint/tendermint => github.com/agoric-labs/cometbft v0.34.27-alpha.agoric.2 | |||
There was a problem hiding this comment.
New version has been tagged with the BlockParams.MaxBytes change
Suggested change
| replace github.com/tendermint/tendermint => github.com/agoric-labs/cometbft v0.34.27-alpha.agoric.2 | |
| replace github.com/tendermint/tendermint => github.com/agoric-labs/cometbft v0.34.27-alpha.agoric.3 |
JimLarson
force-pushed
the
8223-ibc-4
branch
from
52c2334 to
74d8913
Compare
|
PTAL @michaelfig @mhofman |
michaelfig
approved these changes
Nov 12, 2023
The backport referenced above has the agd process hang around after halting. Wrote a wrapper utility which scans stderr for the halt application message, interrupts the process, then propagates its error signal. Conventional shell scripting is not up to the challenge of expressing this behavior.
…#305" This reverts commit efcc3b0. We decided to roll back the problematic change (agoric-labs/cosmos-sdk#305).
JimLarson
force-pushed
the
8223-ibc-4
branch
from
e9b14df to
49d28f7
Compare
mhofman
pushed a commit
that referenced
this pull request
Dec 6, 2023
feat: update ibc-go to v4, adapt packages and API
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #8223
Description
Upgrade to ibc-go v4.4.2. Entails upgrades of cosmos-sdk to v0.45.16 and tendermint to cometbft v0.34.27.
Security Considerations
Closes any security issues that these upgrades address.
Scaling Considerations
N/A
Documentation Considerations
N/A
Testing Considerations
See test plan document.
Upgrade Considerations
Yes.