fix(casting): dont crash on bad capdata #8562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samsiegart
force-pushed
the
sam/casting-capdata-errors
branch
2 times, most recently
from
87aa97a to
eca302f
Compare
michaelfig
approved these changes
Nov 23, 2023
packages/casting/src/types.js
Outdated
| @@ -40,14 +40,18 @@ export {}; | |||
| */ | |||
|
|
|||
| /** | |||
| * @see {ChangeFollower} | |||
| * @template T | |||
There was a problem hiding this comment.
The base no longer needs to be a template.
Suggested change
| * @template T |
There was a problem hiding this comment.
Ah good catch, removed
packages/casting/src/types.js
Outdated
| /** | ||
| * @see {ChangeFollower} | ||
| * @template T | ||
| * @typedef {ValueFollowerBase<T> & ({ value: T } | { value: undefined, error: any })} ValueFollowerElement |
There was a problem hiding this comment.
Suggested change
| * @typedef {ValueFollowerBase<T> & ({ value: T } | { value: undefined, error: any })} ValueFollowerElement | |
| * @typedef {ValueFollowerBase & ({ value: T } | { value: undefined, error: any })} ValueFollowerElement |
samsiegart
force-pushed
the
sam/casting-capdata-errors
branch
from
eca302f to
8f4ba3a
Compare
mhofman
pushed a commit
that referenced
this pull request
Dec 6, 2023
fix(casting): dont crash on bad capdata
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs Agoric/ui-kit#57
refs #8579
Explanation in the comment thread of the issue. TL;DR - The follower was crashing silently after hitting bad capdata. This change makes it so that instead it surfaces an
errorinstead of avaluein that case, and keeps yielding more values.Added a unit test to ensure that it properly surfaces the error and can keep yielding more values afterwards.