-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade SUNDIALS to 7.1.1 #2513
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2513 +/- ##
===========================================
+ Coverage 77.75% 77.84% +0.08%
===========================================
Files 323 325 +2
Lines 20915 21048 +133
Branches 1446 1472 +26
===========================================
+ Hits 16262 16384 +122
+ Misses 4650 4637 -13
- Partials 3 27 +24
Flags with carried forward coverage won't be shown. Click here to find out more.
|
8d6f107
to
3410ede
Compare
f3284b2
to
9865402
Compare
…8cf6b342b/src/sunmatrix/sparse/sunmatrix_sparse.c#L625C1-L694C2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙏
We've been lagging behind SUNDIALS development. This updates the SUNDIALS library from v5.8.0 to v7.1.1.
Note:
cmake/tpl/FindKLU.cmake
from Fix aliasing potentialALIAS
targetSuiteSparse::KLU
LLNL/sundials#582sundials/src/sunmatrix/sparse/sunmatrix_sparse.c:SUNMatScaleAddI_Sparse
from Bugfix/sparse add i LLNL/sundials#584, fixing [BUG] out-of-bounds write in SUNMatScaleAddI_Sparse LLNL/sundials#581The majority of changes inside amici are related to the introduction of SUNContext, which is required for the construction of all SUNDIALS objects. Other trivial changes are related to renamed types and macros.
Furthermore, the error handling strategy has changed. As a consequence, simulation error messages will look slightly different.
Closes #1565