Fix aliasing potential ALIAS target SuiteSparse::KLU
#582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes a CMake configuration issue related to aliasing an ``ALIAS`` target when using ``ENABLE_KLU=ON`` in combination with a static-only build of SuiteSparse. See LLNL#579 for details. Fixes LLNL#579. Signed-off-by: Daniel Weindl <[email protected]>
dweindl
requested review from
balos1,
gardner48,
cswoodward and
drreynolds
as code owners
drreynolds
reviewed
Sep 30, 2024
Co-authored-by: Daniel R. Reynolds <[email protected]>
drreynolds
approved these changes
Sep 30, 2024
balos1
approved these changes
Sep 30, 2024
dweindl
added a commit
to AMICI-dev/AMICI
that referenced
this pull request
Oct 7, 2024
We've been lagging behind SUNDIALS development. This updates the SUNDIALS library from v5.8.0 to [v7.1.1](https://sundials.readthedocs.io/en/latest/Changelog_link.html#changes-to-sundials-in-release-7-1-1). Note: * This includes the post-7.1.1 changes to `cmake/tpl/FindKLU.cmake` from LLNL/sundials#582 * This includes the post-7.1.1 changes to [`sundials/src/sunmatrix/sparse/sunmatrix_sparse.c:SUNMatScaleAddI_Sparse`](https://github.com/LLNL/sundials/blob/736369d543cb80956b1ba87377ffc0c8cf6b342b/src/sunmatrix/sparse/sunmatrix_sparse.c#L625C1-L694C2) from LLNL/sundials#584, fixing LLNL/sundials#581 The majority of changes inside amici are related to the introduction of [SUNContext](https://sundials.readthedocs.io/en/latest/sundials/SUNContext_link.html#the-suncontext-type), which is required for the construction of all SUNDIALS objects. Other trivial changes are related to renamed types and macros. Furthermore, the error handling strategy has changed. As a consequence, simulation error messages will look slightly different. Closes #1565
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a CMake configuration issue related to aliasing an
ALIAStarget when usingENABLE_KLU=ONin combination with a static-only build of SuiteSparse.See #579 for details.
Fixes #579.