Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sundials warnings not showing since 7.1.1 upgrade #2550

Closed
dweindl opened this issue Oct 17, 2024 · 1 comment
Closed

Sundials warnings not showing since 7.1.1 upgrade #2550

dweindl opened this issue Oct 17, 2024 · 1 comment
Assignees

Comments

@dweindl
Copy link
Member

dweindl commented Oct 17, 2024

Sundials warnings got lost since sundials 7 upgrade (#2513). (Things like Internal t = 2.13327 and h = 1.33227e-16 are such that t + h = t on the next step.).

This is because there are now separate channels for errors and warnings, see https://sundials.readthedocs.io/en/latest/sundials/Logging_link.html#status-and-error-logging.

It's straightforward to redirect the errors, but for the warnings that are handled through SUNLogger it's less convenient. There doesn't seem to be a good way of redirecting warnings - we either need to read them from a file, or create some slightly customized SUNLogger, using sundials' private API and capture some C stream (, or ignore those warnings).

@dweindl
Copy link
Member Author

dweindl commented Oct 17, 2024

Oh well, the much simpler solution would be just slightly modifying cvProcessError / IDAProcessError to channel the warnings into the error handler instead of the logger.

@dweindl dweindl self-assigned this Oct 18, 2024
dweindl added a commit to dweindl/AMICI that referenced this issue Oct 18, 2024
Disable SUNDIALS's warning-handling through `SUNLogger`.
Instead pipe everything both errors and warnings through
the provided`SUNErrHandlerFn`.

For details, see AMICI-dev#2550.

Fixes AMICI-dev#2550.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant