Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix AmiVector::nvec_ for size 0 #2535

Merged
merged 1 commit into from
Oct 9, 2024
Merged

Conversation

dweindl
Copy link
Member

@dweindl dweindl commented Oct 8, 2024

  • We still need to create an NVector, even if it's empty.
  • Don't pass nullptr as sunctx

Issue introduced in #2513.

Closes #2534.

Copy link

codecov bot commented Oct 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.78%. Comparing base (2784887) to head (62179fb).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #2535   +/-   ##
========================================
  Coverage    77.77%   77.78%           
========================================
  Files          325      325           
  Lines        21048    21047    -1     
  Branches      1472     1473    +1     
========================================
  Hits         16371    16371           
+ Misses        4650     4649    -1     
  Partials        27       27           
Flag Coverage Δ
cpp 73.49% <100.00%> (+<0.01%) ⬆️
cpp_python 34.02% <75.00%> (-0.01%) ⬇️
petab 37.03% <50.00%> (-0.02%) ⬇️
python 72.32% <75.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
include/amici/vector.h 85.36% <100.00%> (+2.43%) ⬆️
src/solver.cpp 77.03% <100.00%> (ø)
src/vector.cpp 86.20% <100.00%> (-0.16%) ⬇️

@dweindl dweindl marked this pull request as ready for review October 8, 2024 14:03
@dweindl dweindl requested a review from a team as a code owner October 8, 2024 14:03
@dweindl dweindl self-assigned this Oct 9, 2024
@dweindl dweindl merged commit e59e415 into AMICI-dev:develop Oct 9, 2024
16 of 18 checks passed
@dweindl dweindl deleted the fix_2534_empty_x branch October 9, 2024 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants