Release: v2.9.0 #1220
Release: v2.9.0 #1220
Conversation
* Request Safe info from Safe apps * Update dependencies * Update yarn.lock file * remove usecallback * Rename initialization messageId from safe-apps-sdk * Fix openOnFocus on AddressBookInput * Fix yarn.lock file * Rollback @material-ui/lab to avoid type errors * dep bump Co-authored-by: Daniel Sanchez <[email protected]> Co-authored-by: Mikhail Mikheev <[email protected]>
Co-authored-by: Mikhail Mikheev <[email protected]>
Co-authored-by: Fernando <[email protected]>
* type validators * safeSelector types * history 5.0.0 breaking changes adaptation * replace simpleMemoize with memoize from lodash because of typing issues * add type definitions for history and react-router-dom * type fixes * yarn lock update * fix router state * more type improvements * validator tests wip * add tests for validators, remove duplicated validators * add error messages to tests * fix minValue error message for inclusive param * Replace jsx.element with react.reactelement * Fix uniqueAddress validator argument type * remove comment in AddCustomToken validator * use absolute import for saferecord in safe paage container
* Prevent failed CI if there is any warning * Update regex * Eslint error Co-authored-by: Mati Dastugue <[email protected]>
* Fix network label * rename component * use interfaceNetwork as a default parameter Co-authored-by: Mati Dastugue <[email protected]> Co-authored-by: Mikhail <[email protected]>
* Add validation for addressBooj * Fix types * Update default value * Update src/logic/addressBook/utils/index.ts Co-authored-by: Fernando <[email protected]> Co-authored-by: Mati Dastugue <[email protected]> Co-authored-by: Mikhail Mikheev <[email protected]> Co-authored-by: Fernando <[email protected]>
* Fix ts error Add type return on fetchCurrencyValues * Add skeleton for loading balance value * Fix texts in uppercase * Adds ETH Icon in currencyValues dropdown * Adds getExchangeRatesUrlFallback Adds support for ETH as currency * Alphabetically sort currencies * Add types * Type formatAmount * Adds formatAmountInUsFormat util function * Add types Uses formatAmountInUsFormat for BALANCE_TABLE_BALANCE_ID * Updates max and min fraction digits on formatAmountInUsFormat Add tests * Updates max and min fraction digits on formatAmountInUsFormat Add tests * Add types * Fix currencyValues types * Adds safeFiatBalancesTotalSelector * Adds total balance to safe header * Fix types * Adds currentCurrency on header * Adds types to getTokenPriceInCurrency * Fix balance currency rate conversion * Add guards for modules * Add guards for modules * Uses console error for api * Remove anys * Redefine CurrencyRateValue types into CurrencyRateValueRecord * Redefine test texts * Use absolute imports * Add types to dispatch * Add guard for no balance value * Fix ESLINT warning * Add types * Fix no balance case * Use optional chaining * Absolute paths * Adds return types Uses BigNumber in safeFiatBalancesTotalSelector * Remove number as type for formatAmountInUsFormat * Uses createStyles to remove any types * Improve total balances display * Fix balances value column * formatAmountInUsFormat feedback * Force boolean evaluation * Fix totalBalance heading styles * Add types * Add types to fetchTokenCurrenciesBalances endpoint * Replaces coinbase dependency by backend for ETH price in USD * Absolute paths * Replaces RecordOf<TokenProps> with Token * Feedback * Trigger buid * Types * Fix tests order * Renames numberFormat to usNumberFormatter Co-authored-by: Mikhail Mikheev <[email protected]>
* Remove spaces * Change naming convention to make clear that only edge whitespaces are removed Fix function documentation in string util * Add trim spaces from address input in AddToken and AddAsset * Use validator type * Trim spaces on Safe App links Co-authored-by: Mati Dastugue <[email protected]> Co-authored-by: Mati Dastugue <[email protected]> Co-authored-by: Mikhail Mikheev <[email protected]>
Dev <- master v2.8.1 Backmerge
* Fix: debounce fetch apps * refactor: fix AddAppForm name and add missing types * add `use-lodash-debounce` hook to test debounce functionality I'm planning to remove this dependency, as it requires to also install `lodash.debounce`. I prefer to implement it ad-hoc. * refactor AddAppForm to use the observable pattern * memoize `getAppInfoFromUrl` to prevent requesting the same information over and over * prevent requesting data if url is not valid * remove logging * prevent validating form before visiting the fields * refactor AddAppForm reorganize code * fix: change `any` to `unknown` * fix: `uitls.ts` types and imports * refactor: rename `isSubmitDisabled` to `onSubmitButtonStatusChange` prop * refactor: rename `agreement` to `agreementAccepted` also, moved `initialValues` to a constant `INITIAL_VALUES` outside the component * refactor: reimplement `useDebounce` hook in-app * refactor: extract app manifest verification to a helper function also fixed types * fix: prevent accessing `contentWindow` if `iframe` is `null` * fix: `getAppInfoFromOrigin` return type also, removed the expected type for the `getAppInfoFromOrigin` calls as it is inferred Co-authored-by: fernandomg <[email protected]> Co-authored-by: Mikhail Mikheev <[email protected]>
* Update Multisend Address * Update Apps loaders not centered * remove empty spaces Co-authored-by: Mikhail Mikheev <[email protected]>
* typechain wip * add types for multisend * type definitions improvements * type safe contract in estimateTxGasCosts * contract type definitions wip * SafeInstance truffle -> web3 migration * fix calls for version * transactions/send enhancements * fix safe recor owner type * Stepper type definitions wip * dep bump * stepper types wip * refactoring stepper component to fix bug in load safe form * stepper types wip, addressbook reducer types wip * finally make it work * Fix ownerlist component hook in load safe * dep bump * dep bump * rollback types/history * add types for gas calc * debugging... * fix using RO web3 for sending txs * update package.json generate-types command * add ts-ignore for stepperpage * db * dep bump * as unknown as AbiItem -> as AbiItem[] * use optional chaining for isExecution in gas esimations * abiITem -> AbiItem[] * fix safeVersion utils tests * fix imports, put upgradeSafe test close to the actual code * add comment about ts-ignore usage * downgrade web3 version
* Avoid constant creation of new web3 object * rollback web3 version, small type fixes in ConnectButton * Use web3 instance in getProviderInfo Co-authored-by: Mikhail Mikheev <[email protected]>
|
@francovenica I see this pr working ok, could you confirm? |
|
Note this issue is still not fixed in dev: #1208 I still have to do part of the regression on basic functionalities and with different wallets. I'll give the final update hopefully before the dev ops team signs out for the day |
|
@francovenica I will take care of #1208 |
|
#1208 is not a release blocker though, so feel free to add this to the next release (e.g. with the addition of the Balancer apps later this week). |
|
@lukasschor it's pretty easy to fix so let's include it, I can do it before Franco starts to work on regression testing |
|
I think Franco already finished part of the regression testing. But if you feel like this is low-risk fix, feel free to include it (we would not do full regression testing on a hotfix either). |
|
@francovenica 1208 should be fixed now. Only in this PR, later when we release we'll backmerge it to development |
|
Travis automatic deployment: |
|
The issue with the app loading out of bounds is fixed in the 1220 PR. Looks good |
|
@francovenica so the release is good to go or you need to do the regression tests? |
|
Still doing regression. I won't make it for today deployment to stg. I'll have Dev done for today and aim for deploying into stg tomorrow |
|
There is an issue signing tx with Leger/Trezor. |
|
Issue with new safes when creating its first tx #1227 |
|
Travis automatic deployment: |
|
Travis automatic deployment: |
|
@francovenica please re-test |
Add Balancer Pool and Exchange Apps.
|
Travis automatic deployment: |
Changes
Remember not to squash this pull request, just a regular merge