Skip to content
This repository has been archived by the owner on Nov 10, 2023. It is now read-only.

(Feature) Balances enhancements #1122

Merged
merged 66 commits into from
Jul 28, 2020
Merged

(Feature) Balances enhancements #1122

merged 66 commits into from
Jul 28, 2020

Conversation

Agupane
Copy link
Contributor

@Agupane Agupane commented Jul 17, 2020 •
edited
Loading

Closes #408
Also closes #444

@Agupane Agupane added the WIP label Jul 17, 2020
@Agupane Agupane self-assigned this Jul 17, 2020
@Agupane Agupane mentioned this pull request Jul 20, 2020
Merged
5 tasks
@ghost
Copy link

ghost commented Jul 23, 2020

Travis automatic deployment:
https://pr1122--safereact.review.gnosisdev.com/app

1 similar comment
@ghost
Copy link

ghost commented Jul 23, 2020

Travis automatic deployment:
https://pr1122--safereact.review.gnosisdev.com/app

@francovenica francovenica mentioned this pull request Jul 23, 2020
Closed
@francovenica
Copy link
Contributor

@Agupane This PR is not loading for me
image.png

@ghost
Copy link

ghost commented Jul 24, 2020

Travis automatic deployment:
https://pr1122--safereact.review.gnosisdev.com/app

@francovenica
Copy link
Contributor

The PR works now

The font of the total was fixed. It changes when you change the type of currency you want in the dropdown.
The Eth round is better, idk if something was done about it. Tried send some eth to try different values to check the round and it looks good

@Agupane Agupane removed the request for review from alongoni July 28, 2020 12:39
@Agupane
Copy link
Contributor Author

Agupane commented Jul 28, 2020

Hey @mikheevm could you give this a look?

@ghost
Copy link

ghost commented Jul 28, 2020

Travis automatic deployment:
https://pr1122--safereact.review.gnosisdev.com/app

mmv08
mmv08 suggested changes Jul 28, 2020
View reviewed changes
src/logic/currencyValues/api/fetchTokenCurrenciesBalances.ts Outdated Show resolved Hide resolved
src/test/logic/token/utils/formatAmount.test.ts Outdated Show resolved Hide resolved
src/test/logic/token/utils/formatAmount.test.ts Outdated Show resolved Hide resolved
src/test/logic/token/utils/formatAmount.test.ts Outdated Show resolved Hide resolved
src/routes/safe/components/Layout/Header/index.tsx Outdated Show resolved Hide resolved
src/routes/safe/components/Balances/dataFetcher.ts Show resolved Hide resolved
src/routes/safe/components/Balances/dataFetcher.ts Outdated Show resolved Hide resolved
src/logic/tokens/utils/formatAmount.ts Outdated Show resolved Hide resolved
@ghost
Copy link

ghost commented Jul 28, 2020

Travis automatic deployment:
https://pr1122--safereact.review.gnosisdev.com/app

1 similar comment
@ghost
Copy link

ghost commented Jul 28, 2020

Travis automatic deployment:
https://pr1122--safereact.review.gnosisdev.com/app

mmv08
mmv08 approved these changes Jul 28, 2020
View reviewed changes
src/logic/tokens/utils/formatAmount.ts Outdated Show resolved Hide resolved
@ghost
Copy link

ghost commented Jul 28, 2020

Travis automatic deployment:
https://pr1122--safereact.review.gnosisdev.com/app

@mmv08 mmv08 merged commit bbfa7d8 into development Jul 28, 2020
@mmv08 mmv08 deleted the balances-enhacements branch July 28, 2020 15:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lukasschor lukasschor lukasschor left review comments

@Uxio0 Uxio0 Uxio0 left review comments

@pablofullana pablofullana pablofullana left review comments

@mmv08 mmv08 mmv08 approved these changes

@francovenica francovenica francovenica approved these changes

@fernandomg fernandomg fernandomg approved these changes

Assignees

@Agupane Agupane

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Buttons in Uppercase Fiat balance improvements
7 participants
@Agupane @lukasschor @francovenica @pablofullana @fernandomg @Uxio0 @mmv08