Skip to content
This repository has been archived by the owner on Nov 10, 2023. It is now read-only.

Fiat balance improvements #408

Closed
lukasschor opened this issue Jan 2, 2020 · 5 comments · Fixed by #1122
Closed

Fiat balance improvements #408

lukasschor opened this issue Jan 2, 2020 · 5 comments · Fixed by #1122
Assignees
@Agupane
Labels
Enhancement ✨ Minor Improvement / changes to existing functionality Major Needs to be fixed for immediate next public release.

Comments

@lukasschor
Copy link
Member

lukasschor commented Jan 2, 2020 •
edited
Loading

ETH as denomination

Give option to have ETH as value denomination.

Ordering

Order the denominations according to

  1. ETH
  2. USD
  3. EUR
  4. Alphabetically sort the other currencies

Show total

Show total value (sum of all other values). Feel free to suggest where this value should ideally be displayed. Keep in mind, after the layout redesign the total will be displayed in the sidebar.

Seperators

image.png

Use US-style thousands separators (commas every three digits) for displaying fiat balances.
@lukasschor lukasschor added Enhancement ✨ Minor Improvement / changes to existing functionality Minor Needs to be fixed within the next 1-3 public releases. labels Jan 2, 2020
@lukasschor lukasschor added Major Needs to be fixed for immediate next public release. and removed Minor Needs to be fixed within the next 1-3 public releases. labels Feb 4, 2020
@lukasschor lukasschor mentioned this issue Feb 12, 2020
Closed
@fernandomg fernandomg mentioned this issue Mar 10, 2020
Closed
@lukasschor lukasschor mentioned this issue Apr 19, 2020
Closed
@Agupane Agupane assigned Agupane and unassigned Agupane Jun 18, 2020
@Agupane
Copy link
Contributor

Agupane commented Jul 17, 2020

Hi @lukasschor I do have a question, the totalizer should count the fiat balances that are not on the current page or it should be only for the current page balances?

@lukasschor
Copy link
Member Author

It should be the total of all balances on this particular Safe.

Eventually, we will use this total also in the new design here:

image

@Agupane Agupane mentioned this issue Jul 17, 2020
Merged
@alongoni
Copy link
Contributor

Hi! @lukasschor here is an option about where we can show the fiat balance without adding vertical space. And keeping in mind the new design (near the Address Info Component).
fiat-balance

cc @Agupane

@lukasschor
Copy link
Member Author

@alongoni How about to the right of the Safe name?

@alongoni
Copy link
Contributor

Yes, looks great!
fiat-balance2

@Agupane Agupane reopened this Jul 28, 2020
@Agupane Agupane closed this as completed Jul 28, 2020
@mmv08 mmv08 mentioned this issue Aug 7, 2020
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Agupane Agupane

Labels
Enhancement ✨ Minor Improvement / changes to existing functionality Major Needs to be fixed for immediate next public release.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

(Feature) Balances enhancements 5afe/safe-react
3 participants
@alongoni @lukasschor @Agupane