Tech Debt: Validator Type definitions

[mmv08]

This PR:

• replace simpleMemoize function with memoize from lodash to fix typings
• add type definitions to validators
• correctly type components that refer props from router
• dependency bump
• a little bit more of type improvements because when you type things correctly errors start to pop up
• Remove duplicated validators
• Add tests for validators

[ghost]

Travis automatic deployment:
https://pr1108--safereact.review.gnosisdev.com/app

[ghost]

Travis automatic deployment:
https://pr1108--safereact.review.gnosisdev.com/app

[ghost]

Travis automatic deployment:
https://pr1108--safereact.review.gnosisdev.com/app

[mmv08]

@francovenica Could you please test sending funds/contract interaction forms for this PR? Especially with the edge cases (balance less than token, balance equal to token balance, etc). Thanks!

[ghost]

Travis automatic deployment:
https://pr1108--safereact.review.gnosisdev.com/app

[ghost]

Travis automatic deployment:
https://pr1108--safereact.review.gnosisdev.com/app

[ghost]

Travis automatic deployment:
https://pr1108--safereact.review.gnosisdev.com/app

[github-actions]

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type	Occurrences	Fixable
Errors	0	0
Warnings	25	0
Ignored	5	N/A

• Result: ✅ success

• Annotations: 25 total

  ---

[warning] @typescript-eslint/explicit-module-boundary-types

Require explicit return and argument types on exported functions' and classes' public class methods

• src/logic/contractInteraction/sources/EtherscanService.ts Line 8 - Missing return type on function.
• src/logic/contractInteraction/sources/EtherscanService.ts Line 39 - Argument 'options' should be typed.
• src/logic/contractInteraction/sources/EtherscanService.ts Line 43 - Missing return type on function.
• src/logic/contractInteraction/sources/EtherscanService.ts Line 43 - Argument 'contractAddress' should be typed.
• src/logic/contractInteraction/sources/EtherscanService.ts Line 43 - Argument 'network' should be typed.
• src/routes/open/container/Open.tsx Line 48 - Missing return type on function.
• src/routes/open/container/Open.tsx Line 48 - Argument 'safeAddress' should be typed.
• src/routes/open/container/Open.tsx Line 48 - Argument 'safeName' should be typed.
• src/routes/open/container/Open.tsx Line 48 - Argument 'ownersNames' should be typed.
• src/routes/open/container/Open.tsx Line 48 - Argument 'ownerAddresses' should be typed.
• src/routes/open/container/Open.tsx Line 56 - Missing return type on function.
• src/routes/open/container/Open.tsx Line 56 - Argument 'values' should be typed.
• src/routes/open/container/Open.tsx Line 56 - Argument 'userAccount' should be typed.
• src/routes/safe/components/Balances/SendModal/screens/SendFunds/index.tsx Line 51 - Missing return type on function.
• src/routes/safe/components/Balances/SendModal/screens/SendFunds/index.tsx Line 51 - Object pattern argument should be typed.
• src/routes/safe/store/middleware/notificationsMiddleware.ts Line 70 - Argument 'store' should be typed.
• src/routes/safe/store/middleware/notificationsMiddleware.ts Line 70 - Argument 'next' should be typed.
• src/routes/safe/store/middleware/notificationsMiddleware.ts Line 70 - Missing return type on function.
• src/routes/safe/store/middleware/notificationsMiddleware.ts Line 70 - Argument 'action' should be typed.
• src/routes/safe/store/selectors/index.ts Line 174 - Missing return type on function.
• src/routes/safe/store/selectors/index.ts Line 177 - Missing return type on function.
• src/routes/safe/store/selectors/index.ts Line 177 - Argument 'safeAddress' should be typed.
• src/routes/safe/store/selectors/index.ts Line 177 - Argument 'safes' should be typed.
• src/store/index.ts Line 87 - Missing return type on function.
• src/store/index.ts Line 87 - Argument 'localState' should be typed with a non-any type.

---

^{Report generated by eslint-plus-action}

[ghost]

Travis automatic deployment:
https://pr1108--safereact.review.gnosisdev.com/app

[mmv08]

@francovenica could you please test this?

[ghost]

Travis automatic deployment:
https://pr1108--safereact.review.gnosisdev.com/app

[fernandomg]

I don't know why it marked those as 'request change' despite I expressly clicked the 'comment' button 🤷‍♂️

[ghost]

Travis automatic deployment:
https://pr1108--safereact.review.gnosisdev.com/app

[ghost]

Travis automatic deployment:
https://pr1108--safereact.review.gnosisdev.com/app

[ghost]

Travis automatic deployment:
https://pr1108--safereact.review.gnosisdev.com/app

[ghost]

Travis automatic deployment:
https://pr1108--safereact.review.gnosisdev.com/app

[mmv08]

I tested this PR and it worked fine: validation works as expected in forms and different scenarios like no token selected, re-validating after changing token etc

[ghost]

Travis automatic deployment:
https://pr1108--safereact.review.gnosisdev.com/app