Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Organize testing #275

Closed
wants to merge 6 commits into from
Closed

Organize testing #275

wants to merge 6 commits into from

Conversation

pem70
Copy link
Collaborator

@pem70 pem70 commented May 31, 2024

What It Does

Refactor unit tests for files class and core into separate files and add more unit tests on uncovered lines.

How to Test

Review Checklist
I certify that I have:

Additional Comments

Copy link

codecov bot commented May 31, 2024

Codecov Report

Attention: Patch coverage is 93.08807% with 62 lines in your changes missing coverage. Please review.

Project coverage is 89.29%. Comparing base (2f36fc2) to head (6a13b4d).
Report is 239 commits behind head on main.

Files with missing lines Patch % Lines
.../zos_files/zowe/zos_files_for_zowe_sdk/datasets.py 89.71% 22 Missing ⚠️
src/zos_files/zowe/zos_files_for_zowe_sdk/uss.py 66.66% 20 Missing ⚠️
src/zos_files/zowe/zos_files_for_zowe_sdk/files.py 77.27% 10 Missing ⚠️
...s_files/zowe/zos_files_for_zowe_sdk/file_system.py 90.56% 5 Missing ⚠️
tests/unit/files/datasets/test_delete.py 86.36% 3 Missing ⚠️
tests/unit/core/test_config.py 96.07% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #275      +/-   ##
==========================================
+ Coverage   86.17%   89.29%   +3.11%     
==========================================
  Files          35       53      +18     
  Lines        2286     2522     +236     
==========================================
+ Hits         1970     2252     +282     
+ Misses        316      270      -46     
Flag Coverage Δ
unittests 89.29% <93.08%> (+3.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

pem70 added 2 commits May 31, 2024 12:28
@pem70 pem70 marked this pull request as ready for review May 31, 2024 17:01
@pem70 pem70 marked this pull request as draft June 3, 2024 19:20
Copy link
Member

@zFernand0 zFernand0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love how the tests were split into their respective classes.
There is more that could be done in the future, but for now this is a really good start.

After some discussion, there will be a new PR that includes all 3 issues:

Don't forget the comments on the previous PR:

CHANGELOG.md Show resolved Hide resolved
Copy link
Member

@traeok traeok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @pem70 for organizing the tests 👍 I left a couple comments, but I don't have any requests for code changes.

CHANGELOG.md Show resolved Hide resolved
tests/unit/core/test_request_handler.py Show resolved Hide resolved
@pem70 pem70 closed this Jun 5, 2024
@pem70
Copy link
Collaborator Author

pem70 commented Jun 5, 2024

Merged with new pull requests

@pem70 pem70 deleted the Organize-testing branch June 5, 2024 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants