-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Organize testing #275
Organize testing #275
Conversation
Signed-off-by: pem70 <[email protected]>
Signed-off-by: pem70 <[email protected]>
Signed-off-by: pem70 <[email protected]>
Signed-off-by: pem70 <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #275 +/- ##
==========================================
+ Coverage 86.17% 89.29% +3.11%
==========================================
Files 35 53 +18
Lines 2286 2522 +236
==========================================
+ Hits 1970 2252 +282
+ Misses 316 270 -46
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: pem70 <[email protected]>
Signed-off-by: pem70 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I love how the tests were split into their respective classes.
There is more that could be done in the future, but for now this is a really good start.
After some discussion, there will be a new PR that includes all 3 issues:
- [chore]: Refactor
files
andjobs
into proper folders #264 - [tests]: Organize tests based on the source structure #265
- [zos-files]
upload_file_to_dsn
does not convert Windows line endings #104
Don't forget the comments on the previous PR:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @pem70 for organizing the tests 👍 I left a couple comments, but I don't have any requests for code changes.
Merged with new pull requests |
What It Does
Refactor unit tests for files class and core into separate files and add more unit tests on uncovered lines.
How to Test
Review Checklist
I certify that I have:
Additional Comments