-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor Files class into proper classes #274
Conversation
Signed-off-by: pem70 <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #274 +/- ##
==========================================
+ Coverage 86.21% 86.54% +0.33%
==========================================
Files 35 38 +3
Lines 2292 2386 +94
==========================================
+ Hits 1976 2065 +89
- Misses 316 321 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: pem70 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM @pem70 thanks for splitting these up into classes and updating the deprecated functions! 👍
I see that the patch coverage is a bit below the 80% minimum, but no worries about this as the other pull request is related and implements more patch coverage for that work 😋
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes LGTM! 😋
I like the direction that was taken with the refactoring.
Left two minor comments, both of which can be addressed in a new PR that combines all 3 issues:
Closing in favor of the next PR in line: |
What It Does
Refactor files.py into separate files. Class Files will be supported still, and each module can run independently.
How to Test
Review Checklist
I certify that I have:
Additional Comments