Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests]: Organize tests based on the source structure #265

Closed
zFernand0 opened this issue May 23, 2024 · 2 comments
Closed

[tests]: Organize tests based on the source structure #265

zFernand0 opened this issue May 23, 2024 · 2 comments
Assignees
Labels
enhancement New feature or request priority-medium
Milestone

Comments

@zFernand0
Copy link
Member

zFernand0 commented May 23, 2024

Is your feature or enhancement request related to a problem or limitation? Please describe

Before the Python SDK reaches the Long Term Support stage, we should reorganize our tests so that they can be easily maintained after the issue below is completed:

Describe your enhancement idea

Ideally we would run individual tests based on what we are fixin/enhancing.

Here is a before and after based on Pytest's structure of FILE_PATH::TEST_CLASS::TEST_METHOD
Before:

  • pytest -s tests/unit/test_zowe_core.py::TestZosmfProfileManager::test_autodiscovery_and_base_profile_loading

After: (this is just an example of how we could split the tests and the source code too)

  • pytest -s tests/unit/files/create/dataset.py::TestPdsCreation::wrong_alcunit
  • pytest -s tests/unit/files/create/dataset.py::TestPdsCreation::wrong_recfm
  • pytest -s tests/unit/jobs/submit/stdin.py::TestJobSubmission::invalid_job_card
  • pytest -s tests/unit/jobs/download/spool.py::TestJobDownloading::invalid_job_id

Describe alternatives you've considered

N/A

Provide any additional context

@zFernand0 zFernand0 added enhancement New feature or request priority-medium labels May 23, 2024
@zFernand0 zFernand0 added this to the v1 LTS milestone May 23, 2024
@github-project-automation github-project-automation bot moved this to New Issues in Zowe CLI Squad May 23, 2024
Copy link

Thank you for raising this enhancement request.
The community has 90 days to vote on it.
If the enhancement receives at least 5 upvotes, it is added to our development backlog.
If it receives fewer votes, the issue is closed.

@zowe-robot zowe-robot moved this from New Issues to Medium Priority in Zowe CLI Squad May 23, 2024
@pem70 pem70 self-assigned this May 30, 2024
@traeok
Copy link
Member

traeok commented May 30, 2024

It might also be worth updating the USS tests to cover more functions in the codebase.

@JTonda JTonda closed this as completed Jun 11, 2024
@github-project-automation github-project-automation bot moved this from Medium Priority to Closed in Zowe CLI Squad Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request priority-medium
Projects
None yet
Development

No branches or pull requests

4 participants