Test that sending with insufficient funds returns a useful error. #1423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fluidvanadium
requested review from
zancas,
AloeareV,
dorianvp,
Oscar-Pepper and
idky137
fluidvanadium
force-pushed
the
generic_insufficient
branch
from
3bf599f
to
e0f5a80
Compare
Oscar-Pepper
previously requested changes
Sep 24, 2024
fluidvanadium
force-pushed
the
generic_insufficient
branch
from
64d2ff1
to
59f0a84
Compare
fluidvanadium
force-pushed
the
generic_insufficient
branch
from
3c1b316
to
a413347
Compare
zancas
approved these changes
Oct 1, 2024
|
My local sanity test run results:
|
zancas
dismissed
Oscar-Pepper’s stale review
I believe all requested changes were made.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
child of #1420
these tests are rare and necessary